think we need to break backwards compatiblity

Author: daquinteroflex

tidy3d/plugins/smatrix/component_modelers/terminal.py

@@ -346,6 +346,7 @@ def _check_port_impedance_sign(Z_numpy: np.ndarray):
 
         return _check_port_impedance_sign(Z_numpy)
 
+    @staticmethod
     def _compute_F(Z_numpy: np.array):
         """Helper to convert port impedance matrix to F, which is used for
         computing generalized scattering parameters."""

tidy3d/plugins/smatrix/run.py

@@ -111,9 +111,7 @@ def compute_power_wave_amplitudes_at_each_port(
 
 def _internal_construct_smatrix(simulation, batch_data: typing.Any = None) -> TerminalPortDataArray:
     """Post process :class:`.BatchData` to generate scattering matrix, for internal use only."""
-    if batch_data:
-        pass
-    else:
+    if batch_data is None:
         batch_data = simulation.batch_data
 
     from tidy3d.plugins.smatrix.utils import ab_to_s