Addressing coverage

Author: marc-flex

tests/test_components/test_heat.py

@@ -40,6 +40,7 @@ def make_heat_mediums():
         heat_spec=SolidSpec(
             capacity=2,
             conductivity=3,
+            density=1,
         ),
         name="solid_medium",
     )
@@ -57,11 +58,24 @@ def test_heat_medium():
         _ = solid_medium.heat_spec.updated_copy(conductivity=-1)
 
     # check we can create solid medium from  SI units
-    _ = td.SolidSpec.from_si_units(
+    solid_from_si = td.SolidMedium.from_si_units(
         conductivity=1,
         capacity=1,
         density=1,
     )
+    assert solid_from_si.conductivity == 1e-6
+    assert solid_from_si.density == 1e-18
+
+    assert solid_from_si == solid_from_si.heat
+
+    with pytest.raises(ValueError):
+        _ = solid_from_si.charge
+
+    with pytest.raises(ValueError):
+        _ = solid_from_si.electrical
+
+    with pytest.raises(ValueError):
+        _ = solid_from_si.optical
 
 
 def make_heat_structures():
@@ -639,8 +653,69 @@ def test_symmetry_expanded(zero_dim_axis):
     data_expanded_cart = mnt_data_cart_expanded.temperature
     data_expanded_ugrid = mnt_data_ugrid_expanded.temperature
 
-    print(data_expanded_ugrid.bounds)
-    print(mnt_bounds)
+    # print(data_expanded_ugrid.bounds)
+    # print(mnt_bounds)
 
     assert np.all(data_expanded_ugrid.bounds == mnt_bounds)
     assert data_expanded_cart.does_cover(mnt_bounds)
+
+
+def test_unsteady_setup():
+    """Test that unsteady setup works correctly."""
+
+    _, solid_medium = make_heat_mediums()
+    solid_structure = td.Structure(
+        geometry=td.Box(center=(0, 0, 0), size=(1, 1, 1)),
+        medium=solid_medium,
+        name="solid_structure",
+    )
+
+    heat_sim = make_heat_sim(include_custom_source=False)
+    unsteady_spec = td.UnsteadyHeatAnalysis(
+        initial_temperature=300, unsteady_spec=td.UnsteadySpec(time_step=0.1, total_time_steps=100)
+    )
+
+    temp_mnt = TemperatureMonitor(size=(1, 1, 1), name="mnt", unstructured=True)
+    bc = HeatBoundarySpec(
+        condition=td.TemperatureBC(temperature=300),
+        placement=StructureBoundary(structure="solid_structure"),
+    )
+
+    heat_sim = heat_sim.updated_copy(
+        structures=[solid_structure],
+        analysis_spec=unsteady_spec,
+        monitors=[temp_mnt],
+        boundary_spec=[bc],
+    )
+
+    with pytest.raises(pd.ValidationError):
+        solid_medium = td.MultiPhysicsMedium(
+            heat=td.SolidMedium(
+                conductivity=3,
+            ),
+            name="solid_medium",
+        )
+        new_struct = solid_structure.updated_copy(medium=solid_medium)
+        _ = heat_sim.updated_copy(structures=[new_struct])
+
+    with pytest.raises(pd.ValidationError):
+        solid_medium = td.MultiPhysicsMedium(
+            heat=td.SolidMedium(
+                conductivity=3,
+                capacity=2,
+            ),
+            name="solid_medium",
+        )
+        new_struct = solid_structure.updated_copy(medium=solid_medium)
+        _ = heat_sim.updated_copy(structures=[new_struct])
+
+    with pytest.raises(pd.ValidationError):
+        solid_medium = td.MultiPhysicsMedium(
+            heat=td.SolidMedium(
+                conductivity=3,
+                density=2,
+            ),
+            name="solid_medium",
+        )
+        new_struct = solid_structure.updated_copy(medium=solid_medium)
+        _ = heat_sim.updated_copy(structures=[new_struct])

tests/test_components/test_heat_charge.py

@@ -755,6 +755,11 @@ def test_monitor_crosses_medium(mediums, structures, heat_simulation, conduction
             medium=solid_no_heat, structures=[solid_struct_no_heat], monitors=[temp_monitor]
         )
 
+    # check error is raised in voltage monitor doesn't cross a conducting medium
+    with pytest.raises(pd.ValidationError):
+        volt_mnt = td.SteadyPotentialMonitor(center=(0, 0, 0), size=(0, td.inf, td.inf))
+        _ = conduction_simulation.updated_copy(monitors=[volt_mnt])
+
 
 def test_heat_charge_mnt_data(
     temperature_monitor_data, voltage_monitor_data, capacitance_monitor_data
@@ -878,6 +883,26 @@ def test_sim_data_plotting(simulation_data):
         heat_sim_data.updated_copy(simulation=sim)
 
 
+def test_conduction_simulation_has_conductors(conduction_simulation, structures):
+    """Test whether error is raised if conduction simulation has no conductors."""
+
+    with pytest.raises(pd.ValidationError):
+        _ = conduction_simulation.updated_copy(
+            monitors=[],
+            structures=[structures["insulator_structure"]],
+        )
+
+
+def test_coupling_source(conduction_simulation, heat_simulation):
+    """Test whether the coupling source can be applied."""
+
+    with pytest.raises(pd.ValidationError):
+        _ = conduction_simulation.updated_copy(sources=[td.HeatFromElectricSource()])
+
+    with pytest.raises(pd.ValidationError):
+        _ = heat_simulation.updated_copy(sources=[td.HeatFromElectricSource()])
+
+
 # --------------------------
 # Test Classes with Fixtures
 # --------------------------
@@ -1051,6 +1076,13 @@ def test_charge_simulation(
             )
             _ = sim.updated_copy(boundary_spec=[bc_p, new_bc_n])
 
+        # test error is raised when more than one voltage array is provided
+        with pytest.raises(pd.ValidationError):
+            new_bc_p = bc_p.updated_copy(
+                condition=td.VoltageBC(source=td.DCVoltageSource(voltage=[1, 2]))
+            )
+            _ = sim.updated_copy(boundary_spec=[new_bc_p, bc_n])
+
     def test_doping_distributions(self):
         """Test doping distributions."""
         # Implementation needed

tidy3d/components/material/tcad/heat.py

@@ -31,17 +31,15 @@ def heat(self):
 
     @property
     def charge(self):
-        return ValueError(f"A `charge` medium does not exist in this Medium definition: {self}")
+        raise ValueError(f"A `charge` medium does not exist in this Medium definition: {self}")
 
     @property
     def electrical(self):
-        return ValueError(
-            f"An `electrical` medium does not exist in this Medium definition: {self}"
-        )
+        raise ValueError(f"An `electrical` medium does not exist in this Medium definition: {self}")
 
     @property
     def optical(self):
-        return ValueError(f"An `optical` medium does not exist in this Medium definition: {self}")
+        raise ValueError(f"An `optical` medium does not exist in this Medium definition: {self}")
 
 
 class FluidMedium(AbstractHeatMedium):

tidy3d/components/tcad/simulation/heat_charge.py

@@ -363,8 +363,7 @@ def _check_cross_solids(objs: Tuple[Box, ...], values: Dict) -> Tuple[int, ...]:
                     isinstance(medium.heat_spec, SolidMedium) for medium in medium_set
                 )
                 crosses_elec_spec = any(
-                    any([isinstance(medium.charge, medium_i)] for medium_i in valid_electric_medium)
-                    for medium in medium_set
+                    isinstance(medium.charge, valid_electric_medium) for medium in medium_set
                 )
             else:
                 # approximate check for volumetric objects based on bounding boxes
@@ -377,10 +376,7 @@ def _check_cross_solids(objs: Tuple[Box, ...], values: Dict) -> Tuple[int, ...]:
                 crosses_elec_spec = any(
                     obj.intersects(structure.geometry)
                     for structure in total_structures
-                    if any(
-                        [isinstance(structure.medium.charge, medium_i)]
-                        for medium_i in valid_electric_medium
-                    )
+                    if isinstance(structure.medium.charge, valid_electric_medium)
                 )
 
             if not crosses_solid:
@@ -395,8 +391,8 @@ def _check_cross_solids(objs: Tuple[Box, ...], values: Dict) -> Tuple[int, ...]:
     def _monitors_cross_solids(cls, val, values):
         """Error if monitors does not cross any solid medium."""
 
-        if val is None:
-            return val
+        # if val is None:
+        #     return val
 
         failed_solid_idx, failed_elect_idx = cls._check_cross_solids(val, values)