Probably the issue is the caching

Author: daquinteroflex

tidy3d/plugins/smatrix/component_modelers/terminal.py

@@ -321,7 +321,7 @@ def _monitor_data_at_port_amplitude(
 
         a = SMatrixData(a=self._construct_smatrix())
         data = TerminalComponentModelerData(
-            simulation=self, data=a
+            simulation=self, data=(a,)
         )._monitor_data_at_port_amplitude(
             port=port, sim_data=sim_data, monitor_data=monitor_data, a_port=a_port
         )
@@ -335,7 +335,7 @@ def get_antenna_metrics_data(
         from tidy3d.plugins.smatrix.data.data import SMatrixData, TerminalComponentModelerData
 
         a = SMatrixData(a=self._construct_smatrix())
-        data = TerminalComponentModelerData(simulation=self, data=a).get_antenna_metrics_data(
+        data = TerminalComponentModelerData(simulation=self, data=(a,)).get_antenna_metrics_data(
             port_amplitudes=port_amplitudes, monitor_name=monitor_name
         )
         return data
@@ -358,14 +358,14 @@ def port_reference_impedances(self) -> PortDataArray:
         from tidy3d.plugins.smatrix.data.data import SMatrixData, TerminalComponentModelerData
 
         a = SMatrixData(a=self._construct_smatrix())
-        data = TerminalComponentModelerData(simulation=self, data=a).port_reference_impedances
+        data = TerminalComponentModelerData(simulation=self, data=(a,)).port_reference_impedances
         return data
 
     def _port_reference_impedances(self, batch_data) -> PortDataArray:
         from tidy3d.plugins.smatrix.data.data import SMatrixData, TerminalComponentModelerData
 
         a = SMatrixData(a=self._construct_smatrix())
-        data = TerminalComponentModelerData(simulation=self, data=a).port_reference_impedances
+        data = TerminalComponentModelerData(simulation=self, data=(a,)).port_reference_impedances
         return data
 
     @staticmethod

tidy3d/plugins/smatrix/data/data.py

@@ -170,7 +170,9 @@ def get_antenna_metrics_data(
     @cached_property
     def port_reference_impedances(self) -> PortDataArray:
         """The reference impedance used at each port for definining power wave amplitudes."""
-        return self._port_reference_impedances(self.simulation.batch_data)
+        from tidy3d.plugins.smatrix.run import _port_reference_impedances
+
+        return _port_reference_impedances(self.simulation.batch_data)
 
     def compute_power_wave_amplitudes_at_each_port(
         self, port_reference_impedances: PortDataArray, sim_data: SimulationData