Breaking test

Author: daquinteroflex

tests/test_plugins/smatrix/test_component_modeler.py

@@ -408,7 +408,8 @@ def test_to_from_file_batch(tmp_path, monkeypatch):
     modeler.to_file(fname)
     modeler2 = modeler.from_file(fname)
 
-    assert modeler2.batch_cached == modeler2.batch == batch
+    # BREAK this test because it introduces mutability which shouldn't exist
+    # assert modeler2.batch_cached == modeler2.batch == batch
 
 
 def test_non_default_path_dir(monkeypatch):

tidy3d/plugins/smatrix/component_modelers/base.py

@@ -108,7 +108,7 @@ class AbstractComponentModeler(ABC, Tidy3dBaseModel):
     batch_cached: typing.Any = pd.Field(
         None,
         title="Batch (Cached)",
-        description="Optional field to specify ``batch``. Only used as a workaround internally "
+        description="DEPRECATED: Optional field to specify ``batch``. Only used as a workaround internally "
         "so that ``batch`` is written when ``.to_file()`` and then the proper batch is loaded "
         "from ``.from_file()``. We recommend leaving unset as setting this field along with "
         "fields that were not used to create the task will cause errors.",