Fixed some bugs in HeatChargeSimulation.plot_sources(). It runs without crashing with the default argument (swap_axes=False). But it does not produce the correct graphical result when swap_axes=True.

Author: jewettaijfc

tidy3d/components/tcad/simulation/heat.py

@@ -70,6 +70,7 @@ def plot_heat_conductivity(
         colorbar: str = "conductivity",
         hlim: Optional[tuple[float, float]] = None,
         vlim: Optional[tuple[float, float]] = None,
+        swap_axes: bool = False
     ) -> Ax:
         """Plot each of simulation's components on a plane defined by one nonzero x,y,z coordinate.
 
@@ -121,4 +122,5 @@ def plot_heat_conductivity(
             property=plot_type,
             hlim=hlim,
             vlim=vlim,
+            swap_axes=swap_axes,
         )

tidy3d/components/tcad/simulation/heat_charge.py

@@ -1190,7 +1190,7 @@ def plot_boundaries(
             ]
 
         for bc_spec, shape in new_boundaries:
-            ax = self._plot_boundary_condition(shape=shape, boundary_spec=bc_spec, ax=ax, swap_axes=swap_axes)
+            ax = self._plot_boundary_condition(shape=shape, boundary_spec=bc_spec, ax=ax)
 
         # clean up the axis display
         ax = self.add_ax_lims(axis=axis, ax=ax, swap_axes=swap_axes)
@@ -1220,11 +1220,11 @@ def _get_bc_plot_params(self, boundary_spec: HeatChargeBoundarySpec) -> PlotPara
         return plot_params
 
     def _plot_boundary_condition(
-        self, shape: Shapely, boundary_spec: HeatChargeBoundarySpec, ax: Ax, swap_axes: bool = False
+        self, shape: Shapely, boundary_spec: HeatChargeBoundarySpec, ax: Ax
     ) -> Ax:
         """Plot a structure's cross section shape for a given boundary condition."""
         plot_params_bc = self._get_bc_plot_params(boundary_spec=boundary_spec)
-        ax = self.plot_shape(shape=shape, plot_params=plot_params_bc, ax=ax, swap_axes=swap_axes)
+        ax = self.plot_shape(shape=shape, plot_params=plot_params_bc, ax=ax)
         return ax
 
     @staticmethod
@@ -1454,6 +1454,7 @@ def _construct_heat_charge_boundaries(
         structures: list[Structure],
         plane: Box,
         boundary_spec: list[HeatChargeBoundarySpec],
+        swap_axes: bool = False,
     ) -> list[tuple[HeatChargeBoundarySpec, Shapely]]:
         """Compute list of boundary lines to plot on plane.
 
@@ -1476,7 +1477,7 @@ def _construct_heat_charge_boundaries(
         shapes = []  # structure name, structure medium, shape, bounds
         for structure in structures:
             # get list of Shapely shapes that intersect at the plane
-            shapes_plane = plane.intersections_with(structure.geometry)
+            shapes_plane = plane.intersections_with(structure.geometry, swap_axes=swap_axes)
 
             # append each of them and their medium information to the list of shapes
             for shape in shapes_plane:
@@ -1600,7 +1601,6 @@ def plot_sources(
                     source_max=source_max,
                     shape=shape,
                     ax=ax,
-                    swap_axes=swap_axes,
                 )
 
         # clean up the axis display