updated primitives.py and reverted monitor.py to its original state (I think)

Author: jewettaijfc

tidy3d/components/geometry/primitives.py

@@ -378,7 +378,8 @@ def _update_from_bounds(self, bounds: tuple[float, float], axis: Axis) -> Cylind
 
     @verify_packages_import(["trimesh"])
     def _do_intersections_tilted_plane(
-        self, normal: Coordinate, origin: Coordinate, to_2D: MatrixReal4x4
+        self, normal: Coordinate, origin: Coordinate, to_2D: MatrixReal4x4,
+        transpose: bool = False,
     ) -> list[Shapely]:
         """Return a list of shapely geometries at the plane specified by normal and origin.
 
@@ -390,6 +391,8 @@ def _do_intersections_tilted_plane(
             Vector defining the plane origin.
         to_2D : MatrixReal4x4
             Transformation matrix to apply to resulting shapes.
+        transpose : bool = False
+            Optional: Swap coordinates in the plane perpendicular to the normal vector?
 
         Returns
         -------
@@ -400,7 +403,7 @@ def _do_intersections_tilted_plane(
         """
         import trimesh
 
-        z0, (x0, y0) = self.pop_axis(self.center, self.axis)
+        z0, (x0, y0) = self.pop_axis(self.center, self.axis, transpose=transpose)
         half_length = self.finite_length_axis / 2
 
         z_top = z0 + half_length
@@ -442,7 +445,7 @@ def _do_intersections_tilted_plane(
         x = np.hstack((x_bot, x_top))
         y = np.hstack((y_bot, y_top))
         z = np.hstack((np.full_like(x_bot, z_bot), np.full_like(x_top, z_top)))
-        vertices = np.vstack(self.unpop_axis(z, (x, y), self.axis)).T
+        vertices = np.vstack(self.unpop_axis(z, (x, y), self.axis, transpose=transpose)).T
 
         if x_bot.shape[0] == 1:
             m = 1

tidy3d/components/monitor.py

@@ -993,7 +993,6 @@ def local_origin(self) -> Coordinate:
     def window_parameters(
         self,
         custom_bounds: Bound = None,
-        transpose: bool = False,
     ) -> tuple[Size, Coordinate, Coordinate]:
         """Return the physical size of the window transition region based on the monitor's size
         and optional custom bounds (useful in case the monitor has infinite dimensions). The window
@@ -1008,7 +1007,7 @@ def window_parameters(
         if self.size.count(0.0) != 1:
             return window_size, window_minus, window_plus
 
-        _, plane_inds = self.pop_axis([0, 1, 2], axis=self.size.index(0.0), transpose=transpose)
+        _, plane_inds = self.pop_axis([0, 1, 2], axis=self.size.index(0.0))
 
         for i, ind in enumerate(plane_inds):
             if custom_bounds: