Possibly we have to break backwards compatibility

Author: daquinteroflex

tidy3d/plugins/smatrix/component_modelers/terminal.py

@@ -198,9 +198,7 @@ def _source_time(self):
 
     def _construct_smatrix(self) -> TerminalPortDataArray:
         """Post process :class:`.BatchData` to generate scattering matrix."""
-        return self._internal_construct_smatrix(
-            batch_data=self._internal_construct_smatrix(self.batch_data)
-        )
+        return self._internal_construct_smatrix(batch_data=self.batch_data)
 
     def _internal_construct_smatrix(self, batch_data) -> TerminalPortDataArray:
         """Post process :class:`.BatchData` to generate scattering matrix, for internal use only."""
@@ -400,14 +398,12 @@ def port_reference_impedances(self) -> PortDataArray:
         data = TerminalComponentModelerData(simulation=self, data=a).port_reference_impedances
         return data
 
-    # def _port_reference_impedances(self, batch_data) -> PortDataArray:
-    #     from tidy3d.plugins.smatrix.data.data import SMatrixData, TerminalComponentModelerData
-    #
-    #     a = SMatrixData(a=self._construct_smatrix())
-    #     data = TerminalComponentModelerData(simulation=self, data=a)._port_reference_impedances(
-    #         batch_data=batch_data
-    #     )
-    #     return data
+    def _port_reference_impedances(self, batch_data) -> PortDataArray:
+        from tidy3d.plugins.smatrix.data.data import SMatrixData, TerminalComponentModelerData
+
+        a = SMatrixData(a=self._construct_smatrix())
+        data = TerminalComponentModelerData(simulation=self, data=a).port_reference_impedances
+        return data
 
     @staticmethod
     def s_to_z(