Skip to content

Commit b7e2a38

Browse files
Passing local tests
1 parent 8bdd1cf commit b7e2a38

File tree

14 files changed

+83
-58
lines changed

14 files changed

+83
-58
lines changed

tests/test_plugins/smatrix/test_component_modeler.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88

99
import tidy3d as td
1010
from tidy3d.exceptions import SetupError, Tidy3dKeyError
11-
from tidy3d.plugins.smatrix import ComponentModeler, ComponentModelerData, Port, IndexSimulationData
11+
from tidy3d import IndexSimulationData
12+
from tidy3d.plugins.smatrix import ComponentModeler, ComponentModelerData, Port
1213
from tidy3d.web.api.container import Batch
1314

1415
from ...utils import run_emulated

tests/test_plugins/smatrix/test_terminal_component_modeler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@
1515
CustomCurrentIntegral2D,
1616
VoltageIntegralAxisAligned,
1717
)
18+
from tidy3d import IndexSimulationData
1819
from tidy3d.plugins.smatrix import (
1920
AbstractComponentModeler,
2021
CoaxialLumpedPort,
2122
LumpedPort,
2223
PortDataArray,
23-
IndexSimulationData,
2424
TerminalComponentModeler,
2525
TerminalComponentModelerData,
2626
TerminalPortDataArray,

tidy3d/__init__.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@
3535
HeatSimulationData,
3636
VolumeMesherData,
3737
)
38+
from tidy3d.components.index import IndexSimulation
39+
from tidy3d.components.data.index import IndexSimulationData
3840
from tidy3d.components.tcad.data.types import (
3941
SteadyCapacitanceData,
4042
SteadyElectricFieldData,
@@ -570,6 +572,8 @@ def set_logging_level(level: str) -> None:
570572
"HeatSource",
571573
"HeuristicPECStaircasing",
572574
"HuraySurfaceRoughness",
575+
"IndexSimulation",
576+
"IndexSimulationData",
573577
"IndexPerturbation",
574578
"IndexedDataArray",
575579
"IndexedFieldVoltageDataArray",

tidy3d/components/data/index.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
from tidy3d.components.simulaton_types import SimulationDataType
1+
from __future__ import annotations
2+
23
from tidy3d.components.base import Tidy3dBaseModel
4+
from tidy3d.components.simulaton_types import SimulationDataType
5+
36

47
class IndexSimulationData(Tidy3dBaseModel):
58
index: tuple[str, ...]
@@ -21,4 +24,4 @@ def __getitem__(self, index: str) -> SimulationDataType:
2124
for i, index_i in enumerate(self.index):
2225
if index_i == index:
2326
return self.data[i]
24-
raise KeyError(f"Index '{index}' not found.")
27+
raise KeyError(f"Index '{index}' not found.")

tidy3d/components/index.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1-
from tidy3d.components.simulaton_types import SimulationType
1+
from __future__ import annotations
2+
23
from tidy3d.components.base import Tidy3dBaseModel
4+
from tidy3d.components.simulaton_types import SimulationType
5+
36

47
class IndexSimulation(Tidy3dBaseModel):
58
index: tuple[str, ...]
@@ -22,5 +25,3 @@ def __getitem__(self, index: str) -> SimulationType:
2225
if index_i == index:
2326
return self.simulation[i]
2427
raise KeyError(f"Index '{index}' not found.")
25-
26-

tidy3d/components/simulaton_types.py

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,7 @@
1-
21
from __future__ import annotations
32

4-
import json
5-
from typing import Callable, Optional, Union
6-
7-
import pydantic.v1 as pd
8-
from pydantic.v1 import BaseModel
3+
from typing import Union
94

10-
from tidy3d import log
11-
from tidy3d.components.base import _get_valid_extension
125
from tidy3d.components.data.monitor_data import ModeSolverData
136
from tidy3d.components.data.sim_data import SimulationData
147
from tidy3d.components.eme.data.sim_data import EMESimulationData
@@ -19,19 +12,11 @@
1912
from tidy3d.components.tcad.data.sim_data import (
2013
HeatChargeSimulationData,
2114
HeatSimulationData,
22-
VolumeMesherData,
2315
)
2416
from tidy3d.components.tcad.mesher import VolumeMesher
2517
from tidy3d.components.tcad.simulation.heat import HeatSimulation
2618
from tidy3d.components.tcad.simulation.heat_charge import HeatChargeSimulation
2719
from tidy3d.plugins.mode.mode_solver import ModeSolver
28-
from tidy3d.web.core.file_util import (
29-
read_simulation_from_hdf5,
30-
read_simulation_from_hdf5_gz,
31-
read_simulation_from_json,
32-
)
33-
from tidy3d.web.core.stub import TaskStub, TaskStubData
34-
from tidy3d.web.core.types import TaskType
3520

3621
SimulationType = Union[
3722
Simulation,
@@ -50,4 +35,3 @@
5035
ModeSolverData,
5136
ModeSimulationData,
5237
]
53-

tidy3d/plugins/smatrix/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@
3838
"ComponentModeler",
3939
"ComponentModelerData",
4040
"ComponentModelerDataLumpedPort",
41-
"ComponentModelerType",
4241
"ComponentModelerDataType",
42+
"ComponentModelerType",
4343
"LumpedPort",
4444
"MicrowaveSMatrixData",
4545
"ModalPortDataArray",

tidy3d/plugins/smatrix/data/modal.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,9 @@
55
import pydantic.v1 as pd
66

77
from tidy3d.components.base import Tidy3dBaseModel, cached_property
8-
from tidy3d.components.data.sim_data import SimulationData
98
from tidy3d.components.data.index import IndexSimulationData
109
from tidy3d.plugins.smatrix.component_modelers.modal import ComponentModeler
1110
from tidy3d.plugins.smatrix.data.data_array import ModalPortDataArray
12-
from tidy3d.plugins.smatrix.ports.types import PortReferenceType
13-
1411

1512

1613
class ComponentModelerData(Tidy3dBaseModel):

tidy3d/plugins/smatrix/run.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,12 @@ def create_batch(
5050
else:
5151
group_id_dict = None
5252

53-
batch = Batch(simulations=modeler.sim_dict, parent_tasks=parent_task_dict, group_ids=group_id_dict, **kwargs)
53+
batch = Batch(
54+
simulations=modeler.sim_dict,
55+
parent_tasks=parent_task_dict,
56+
group_ids=group_id_dict,
57+
**kwargs,
58+
)
5459
batch.to_file(filepath)
5560
return batch
5661

tidy3d/plugins/smatrix/web/api/mode.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,13 @@
2121
from tidy3d.exceptions import SetupError, WebError
2222
from tidy3d.log import get_logging_console, log
2323
from tidy3d.plugins.mode.mode_solver import MODE_MONITOR_NAME, ModeSolver
24-
from tidy3d.version import __version__
2524
from tidy3d.plugins.smatrix.web.core.core_config import get_logger_console
2625
from tidy3d.plugins.smatrix.web.core.environment import Env
2726
from tidy3d.plugins.smatrix.web.core.http_util import http
2827
from tidy3d.plugins.smatrix.web.core.s3utils import download_file, download_gz_file, upload_file
2928
from tidy3d.plugins.smatrix.web.core.task_core import Folder
3029
from tidy3d.plugins.smatrix.web.core.types import PayType, ResourceLifecycle, Submittable
30+
from tidy3d.version import __version__
3131

3232
SIMULATION_JSON = "simulation.json"
3333
SIM_FILE_HDF5_GZ = "simulation.hdf5.gz"

0 commit comments

Comments
 (0)