Fixing formatting and minor error

Author: damiano-flex

tidy3d/components/tcad/boundary/heat.py

@@ -40,7 +40,8 @@ class HeatFluxBC(HeatChargeBC):
         units=HEAT_FLUX,
     )
 
-#TODO Should I adapt to Tidy3D units (e.g. micrometers), or keep the original ones?
+
+# TODO Should I adapt to Tidy3D units (e.g. micrometers), or keep the original ones?
 THERMAL_CONDUCTIVITY_UNITS = "W/(m*K)"
 DYNAMIC_VISCOSITY_UNITS = "Pa*s"
 SPECIFIC_HEAT_UNITS = "J/(kg*K)"
@@ -49,6 +50,7 @@ class HeatFluxBC(HeatChargeBC):
 LENGTH_UNITS = "m"
 ACCELERATION_UNITS = "m/s**2"
 
+
 class NaturalConvectionVerticalSpec(HeatChargeBC):
     """
     Specification for natural convection from a vertical plate.
@@ -58,6 +60,7 @@ class NaturalConvectionVerticalSpec(HeatChargeBC):
     values as 'base' and 'exponent' for a generalized heat flux equation
     q = base * (T_surf - T_fluid)^exponent.
     """
+
     # --- Input Parameters ---
     fluid_k: pd.NonNegativeFloat = pd.Field(
         title="Fluid Thermal Conductivity",
@@ -98,14 +101,9 @@ class NaturalConvectionVerticalSpec(HeatChargeBC):
     )
 
     def _compute_parameters(self):
-
         # Calculate the Rayleigh Number (Ra_L)
         rayleigh_numerator_notemp = (
-                self.gravity
-                * self.fluid_beta
-                * self.fluid_rho ** 2
-                * self.fluid_Cp
-                * self.plate_L ** 3
+            self.gravity * self.fluid_beta * self.fluid_rho**2 * self.fluid_Cp * self.plate_L**3
         )
         rayleigh_denominator = self.fluid_mu * self.fluid_k
         Ra_L = rayleigh_numerator_notemp / rayleigh_denominator
@@ -122,19 +120,22 @@ def _compute_parameters(self):
         if Ra_L <= 1e9:
             # Laminar Flow
             h_factor_linear = 0.68
-            h_factor_non_linear =  (0.670 * Ra_L ** (1 / 6)) / pr_denominator
+            h_factor_non_linear = (0.670 * Ra_L ** (1 / 6)) / pr_denominator
         elif 1e9 < Ra_L <= 1e13:
             # Turbulent Flow
             h_factor_linear = 0.825
             h_factor_non_linear = (0.387 * Ra_L ** (1 / 6)) / pr_denominator
         else:
-            raise ValueError(f"Ra_l={Ra_L} should be smaller than 1e13 for NaturalConvectionVerticalSpec")
+            raise ValueError(
+                f"Ra_L={Ra_L} should be smaller than 1e13 for NaturalConvectionVerticalSpec"
+            )
 
         h = (self.fluid_k / self.plate_L) * h_factor_linear
         h_nonlinear = (self.fluid_k / self.plate_L) * h_factor_non_linear
-        exponent = 1 + 1/6
+        exponent = 1 + 1 / 6
         return h, h_nonlinear, exponent
 
+
 class ConvectionBC(HeatChargeBC):
     """Convective thermal boundary conditions.
 
@@ -156,6 +157,7 @@ class ConvectionBC(HeatChargeBC):
         units=HEAT_TRANSFER_COEFF,
     )
 
-#TODO Maybe I should find a better place for these lines.
+
+# TODO Maybe I should find a better place for these lines.
 NaturalConvectionVerticalSpec.update_forward_refs()
 ConvectionBC.update_forward_refs()

tidy3d/components/tcad/types.py

@@ -4,7 +4,12 @@
 
 from tidy3d.components.tcad.bandgap import SlotboomBandGapNarrowing
 from tidy3d.components.tcad.boundary.charge import CurrentBC, InsulatingBC, VoltageBC
-from tidy3d.components.tcad.boundary.heat import ConvectionBC, HeatFluxBC, TemperatureBC, NaturalConvectionVerticalSpec
+from tidy3d.components.tcad.boundary.heat import (
+    ConvectionBC,
+    HeatFluxBC,
+    TemperatureBC,
+    NaturalConvectionVerticalSpec,
+)
 from tidy3d.components.tcad.generation_recombination import (
     AugerRecombination,
     RadiativeRecombination,