removed "transpose" argument from some validator functions. (oops. that was an accident.)

Author: jewettaijfc

tidy3d/components/base_sim/simulation.py

@@ -436,7 +436,7 @@ def plot_symmetries(
         matplotlib.axes._subplots.Axes
             The supplied or created matplotlib axes.
         """
-9
+
         normal_axis, _ = Box.parse_xyz_kwargs(x=x, y=y, z=z)
 
         for sym_axis, sym_value in enumerate(self.symmetry):

tidy3d/components/geometry/primitives.py

@@ -502,7 +502,7 @@ def _intersections_normal(self, z: float, transpose: bool = False):
         if radius_offset <= 0:
             return []
 
-        _, (x0, y0) = self.pop_axis(static_self.center, axis=self.axi, transpose=transpose)
+        _, (x0, y0) = self.pop_axis(static_self.center, axis=self.axis, transpose=transpose)
         return [shapely.Point(x0, y0).buffer(radius_offset, quad_segs=_N_SHAPELY_QUAD_SEGS)]
 
     def _intersections_side(self, position, axis, transpose: bool = False):

tidy3d/components/scene.py

@@ -483,7 +483,6 @@ def plot_structures(
                 shape=shape,
                 ax=ax,
                 fill=fill,
-                transpose=transpose,
             )
 
         # clean up the axis display

tidy3d/components/simulation.py

@@ -2711,7 +2711,7 @@ def bloch_with_symmetry(cls, val, values):
 
     @pydantic.validator("boundary_spec", always=True)
     @skip_if_fields_missing(["medium", "size", "structures", "sources"])
-    def plane_wave_boundaries(cls, val, values, transpose: bool = False):
+    def plane_wave_boundaries(cls, val, values):
         """Error if there are plane wave sources incompatible with boundary conditions."""
         boundaries = val.to_list
         sources = values.get("sources")
@@ -2722,7 +2722,7 @@ def plane_wave_boundaries(cls, val, values, transpose: bool = False):
             if not isinstance(source, PlaneWave):
                 continue
 
-            _, tan_dirs = cls.pop_axis([0, 1, 2], axis=source.injection_axis, transpose=transpose)
+            _, tan_dirs = cls.pop_axis([0, 1, 2], axis=source.injection_axis)
             medium_set = Scene.intersecting_media(source, structures)
             medium = medium_set.pop() if medium_set else sim_medium
 
@@ -2765,7 +2765,7 @@ def plane_wave_boundaries(cls, val, values, transpose: bool = False):
 
     @pydantic.validator("monitors", always=True)
     @skip_if_fields_missing(["boundary_spec", "medium", "size", "structures", "sources"])
-    def bloch_boundaries_diff_mnt(cls, val, values, transpose: bool = False):
+    def bloch_boundaries_diff_mnt(cls, val, values):
         """Error if there are diffraction monitors incompatible with boundary conditions."""
 
         monitors = val
@@ -2782,7 +2782,7 @@ def bloch_boundaries_diff_mnt(cls, val, values, transpose: bool = False):
             if not isinstance(source, PlaneWave):
                 continue
 
-            _, tan_dirs = cls.pop_axis([0, 1, 2], axis=source.injection_axis, transpose=transpose)
+            _, tan_dirs = cls.pop_axis([0, 1, 2], axis=source.injection_axis)
             medium_set = Scene.intersecting_media(source, structures)
             medium = medium_set.pop() if medium_set else sim_medium
 
@@ -2805,7 +2805,7 @@ def bloch_boundaries_diff_mnt(cls, val, values, transpose: bool = False):
 
     @pydantic.validator("boundary_spec", always=True)
     @skip_if_fields_missing(["medium", "center", "size", "structures", "sources"])
-    def tfsf_boundaries(cls, val, values, transpose: bool = False):
+    def tfsf_boundaries(cls, val, values):
         """Error if the boundary conditions are incompatible with TFSF sources, if any."""
         boundaries = val.to_list
         sources = values.get("sources")
@@ -2821,7 +2821,7 @@ def tfsf_boundaries(cls, val, values, transpose: bool = False):
             if not isinstance(source, TFSF):
                 continue
 
-            norm_dir, tan_dirs = cls.pop_axis([0, 1, 2], axis=source.injection_axis, transpose=transpose)
+            norm_dir, tan_dirs = cls.pop_axis([0, 1, 2], axis=source.injection_axis)
             src_bounds = source.bounds
 
             # make a dummy source that represents the injection surface to get the intersecting
@@ -3159,14 +3159,14 @@ def _warn_monitor_simulation_frequency_range(cls, val, values):
 
     @pydantic.validator("monitors", always=True)
     @skip_if_fields_missing(["boundary_spec"])
-    def diffraction_monitor_boundaries(cls, val, values, transpose: bool = False):
+    def diffraction_monitor_boundaries(cls, val, values):
         """If any :class:`.DiffractionMonitor` exists, ensure boundary conditions in the
         transverse directions are periodic or Bloch."""
         monitors = val
         boundary_spec = values.get("boundary_spec")
         for monitor in monitors:
             if isinstance(monitor, DiffractionMonitor):
-                _, (n_x, n_y) = monitor.pop_axis(["x", "y", "z"], axis=monitor.normal_axis, transpose=transpose)
+                _, (n_x, n_y) = monitor.pop_axis(["x", "y", "z"], axis=monitor.normal_axis)
                 boundaries = [
                     boundary_spec[n_x].plus,
                     boundary_spec[n_x].minus,
@@ -3230,7 +3230,7 @@ def _projection_monitors_homogeneous(cls, val, values):
         return val
 
     @pydantic.validator("monitors", always=True)
-    def _projection_direction(cls, val, values, transpose: bool = False):
+    def _projection_direction(cls, val, values):
         """Warn if field projection observation points are behind surface projection monitors."""
         # This validator is in simulation.py rather than monitor.py because volume monitors are
         # eventually converted to their bounding surface projection monitors, in which case we
@@ -3268,7 +3268,7 @@ def _projection_direction(cls, val, values, transpose: bool = False):
                         x, y, z = Geometry.sph_2_car(r=monitor.proj_distance, theta=theta, phi=phi)
                     else:
                         pts = monitor.unpop_axis(
-                            monitor.proj_distance, (monitor.x, monitor.y), axis=normal_ind, transpose=transpose
+                            monitor.proj_distance, (monitor.x, monitor.y), axis=normal_ind
                         )
                         x, y, z = pts