Skip to content

Commit daedbca

Browse files
ci: Retrigger from reviews, but always verify-schema
1 parent 6239df6 commit daedbca

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

.github/workflows/tidy3d-python-client-tests.yml

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ on:
1818
- develop
1919
- 'pre/*'
2020
types: ['opened', 'reopened', 'synchronize', 'ready_for_review']
21+
pull_request_review:
22+
types: [submitted]
2123

2224
permissions:
2325
contents: read
@@ -95,6 +97,17 @@ jobs:
9597
local_tests=true
9698
remote_tests=true
9799
fi
100+
101+
# If triggered by PR review and approved
102+
if [[ "$EVENT_NAME" == "pull_request_review" ]]; then
103+
if [[ "$REVIEW_STATE" == "approved" ]]; then
104+
local_tests=true
105+
remote_tests=true
106+
else
107+
local_tests=false
108+
remote_tests=false
109+
fi
110+
fi
98111
99112
# If it's a push to develop
100113
if [[ "$EVENT_NAME" == "push" && "$REF" == "refs/heads/develop" ]]; then
@@ -234,7 +247,7 @@ jobs:
234247
image: ghcr.io/astral-sh/uv:debian
235248
options: --user 31001:61001 # Required slurm-batch UID: slurm GID for tmp/ file removal
236249
concurrency:
237-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.event_name }-${{ matrix.python-version }}-local
250+
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.event_name }}-${{ matrix.python-version }}-local
238251
cancel-in-progress: true
239252
strategy:
240253
matrix:

0 commit comments

Comments
 (0)