fix[web]: use dedicated endpoint for web.delete_old()

Author: yaugenst-flex

CHANGELOG.md

@@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Small (around 1e-4) numerical precision improvements in EME solver.
 - Adjoint source frequency width is adjusted to decay sufficiently before zero frequency when possible to improve accuracy of simulation normalization when using custom current sources.
 - Change `VisualizationSpec` validator for checking validity of user specified colors to only issue a warning if matplotlib is not installed instead of an error.
+- Improved performance of `tidy3d.web.delete_old()` for large folders.
 
 ### Changed
 - `tidy3d.plugins.autograd.interpolate_spline()` and `tidy3d.plugins.autograd.add_at()` can now be called with keyword arguments during tracing.

tests/test_web/test_webapi.py

@@ -448,60 +448,14 @@ def test_delete_old(set_api_key):
         json={"data": {"projectId": TASK_ID, "projectName": PROJECT_NAME}},
         status=200,
     )
-
-    responses.add(
-        responses.GET,
-        f"{Env.current.web_api_endpoint}/tidy3d/projects/{TASK_ID}/tasks",
-        json={"data": [{"taskId": TASK_ID, "createdAt": CREATED_AT}]},
-        status=200,
-    )
-
-    responses.add(
-        responses.GET,
-        f"{Env.current.web_api_endpoint}/tidy3d/tasks/{TASK_ID}",
-        json={
-            "data": {
-                "taskId": TASK_ID,
-                "groupId": "group123",
-                "version": "v1",
-                "createdAt": CREATED_AT,
-            }
-        },
-        status=200,
-    )
-
-    responses.add(
-        responses.DELETE,
-        f"{Env.current.web_api_endpoint}/tidy3d/group/group123/versions",
-        match=[
-            matchers.json_params_matcher(
-                {
-                    "versions": ["v1"],
-                }
-            )
-        ],
-        json={
-            "data": {
-                "taskId": TASK_ID,
-                "createdAt": CREATED_AT,
-            }
-        },
-        status=200,
-    )
-
     responses.add(
         responses.DELETE,
-        f"{Env.current.web_api_endpoint}/tidy3d/tasks/{TASK_ID}",
-        json={
-            "data": {
-                "taskId": TASK_ID,
-                "createdAt": CREATED_AT,
-            }
-        },
+        f"{Env.current.web_api_endpoint}/tidy3d/tasks/{FOLDER_ID}/tasks",
+        json={"data": 0, "warning": "string"},
         status=200,
     )
 
-    delete_old(100)
+    delete_old(days_old=100)
 
 
 @responses.activate

tidy3d/web/api/webapi.py

@@ -4,10 +4,8 @@
 import os
 import tempfile
 import time
-from datetime import datetime, timedelta
 from typing import Callable, Dict, List, Union
 
-import pytz
 from requests import HTTPError
 from rich.progress import Progress
 
@@ -867,15 +865,7 @@ def delete_old(
     folder = Folder.get(folder)
     if not folder:
         return 0
-    tasks = folder.list_tasks()
-    if not tasks:
-        return 0
-    tasks = list(
-        filter(lambda t: t.created_at < datetime.now(pytz.utc) - timedelta(days=days_old), tasks)
-    )
-    for task in tasks:
-        task.delete()
-    return len(tasks)
+    return folder.delete_old(days_old)
 
 
 @wait_for_connection

tidy3d/web/core/task_core.py

@@ -101,6 +101,14 @@ def delete(self):
 
         http.delete(f"tidy3d/projects/{self.folder_id}")
 
+    def delete_old(self, days_old: int) -> int:
+        """Remove folder contents older than ``days_old``."""
+
+        return http.delete(
+            f"tidy3d/tasks/{self.folder_id}/tasks",
+            params={"daysOld": days_old},
+        )
+
     def list_tasks(self) -> List[Tidy3DResource]:
         """List all tasks in this folder.