fix: solve most warnings in test suite & some deprecation warnings too

Author: yaugenst-flex

tests/test_components/test_autograd.py

@@ -2321,10 +2321,16 @@ def objective(center, size):
         sim_data = run_emulated(sim, task_name="adjoint_test")
         return postprocess(sim_data)
 
-    with AssertLogLevel("WARNING", contains_str="autograd tracer"):
+    with (
+        AssertLogLevel("WARNING", contains_str="autograd tracer"),
+        pytest.warns(UserWarning, match="Output seems independent of input."),
+    ):
         grad = ag.grad(objective, argnum=0)(base_sim.center, base_sim.size)
 
-    with AssertLogLevel("WARNING", contains_str="autograd tracer"):
+    with (
+        AssertLogLevel("WARNING", contains_str="autograd tracer"),
+        pytest.warns(UserWarning, match="Output seems independent of input."),
+    ):
         grad = ag.grad(objective, argnum=1)(base_sim.center, base_sim.size)
 
 

tests/test_components/test_heat_charge.py

@@ -1476,16 +1476,16 @@ def test_gaussian_doping_get_contrib():
 
     coords = {"x": [0], "y": [0], "z": [0]}
     contrib = box._get_contrib(coords)
-    assert np.isclose(float(contrib), max_N, rtol=1e-6)
+    assert np.isclose(contrib.item(), max_N, rtol=1e-6)
 
     coords = {"x": [0.5], "y": [0], "z": [0]}
     contrib = box._get_contrib(coords)
-    assert np.isclose(float(contrib), min_N, rtol=1e-6)
+    assert np.isclose(contrib.item(), min_N, rtol=1e-6)
 
     coords = {"x": [0.5 - width / 2], "y": [0], "z": [0]}
     contrib = box._get_contrib(coords)
     expected_value = max_N * np.exp(-width * width / 4 / box.sigma / box.sigma / 2)
-    assert np.isclose(float(contrib), expected_value, rtol=1e-6)
+    assert np.isclose(contrib.item(), expected_value, rtol=1e-6)
 
 
 def test_gaussian_doping_get_contrib_2d_coords():

tests/test_plugins/test_microwave.py

@@ -402,7 +402,7 @@ def test_microstrip_models():
     freqs = Frequency(start=1, stop=1, npoints=1, unit="ghz")
     mline = MLine(frequency=freqs, w=width, h=height, t=thickness, ep_r=eps_r, disp="none")
 
-    assert np.isclose(Z0, mline.Z0[0])
+    assert np.isclose(Z0, mline.z0[0])
     assert np.isclose(eps_eff, mline.ep_reff[0])
 
     # Check end effect length computation
@@ -414,7 +414,7 @@ def test_microstrip_models():
     Z0, eps_eff = mw.models.microstrip.compute_line_params(eps_r, width, height, thickness)
     mline = MLine(frequency=freqs, w=width, h=height, t=thickness, ep_r=eps_r, disp="none")
 
-    assert np.isclose(Z0, mline.Z0[0])
+    assert np.isclose(Z0, mline.z0[0])
     assert np.isclose(eps_eff, mline.ep_reff[0])
 
 
@@ -667,7 +667,7 @@ def test_lobe_measurer_validation():
 
     Urad = np.cos(theta) + 1j * np.sin(theta)
     # Raise error when radiation pattern is complex
-    with pytest.raises(pd.ValidationError):
+    with pytest.raises(pd.ValidationError), pytest.warns(np.exceptions.ComplexWarning):
         mw.LobeMeasurer(
             angle=theta,
             radiation_pattern=Urad,
@@ -794,4 +794,3 @@ def test_lobe_plots(min_value):
     _, ax = plt.subplots(1, 1, subplot_kw={"projection": "polar"})
     ax.plot(theta, Urad, "k")
     lobe_measurer.plot(0, ax)
-    plt.show()

tests/utils.py

@@ -1140,7 +1140,7 @@ def get_spatial_coords_dict(simulation: td.Simulation, monitor: td.Monitor, fiel
 
 def run_emulated(simulation: td.Simulation, path=None, **kwargs) -> td.SimulationData:
     """Emulates a simulation run."""
-    from scipy.ndimage.filters import gaussian_filter
+    from scipy.ndimage import gaussian_filter
 
     x = kwargs.get("x0", 1.0)
 

tidy3d/components/data/unstructured/triangular.py

@@ -675,5 +675,5 @@ def get_cell_volumes(self):
         v0 = self.points[self.cells.sel(vertex_index=0)]
         e01 = self.points[self.cells.sel(vertex_index=1)] - v0
         e02 = self.points[self.cells.sel(vertex_index=2)] - v0
-
-        return 0.5 * np.abs(np.cross(e01, e02))
+        areas = e01[:, 0] * e02[:, 1] - e01[:, 1] * e02[:, 0]
+        return 0.5 * np.abs(areas)

tidy3d/components/geometry/base.py

@@ -2032,7 +2032,7 @@ def _do_intersections_tilted_plane(
         section = mesh.section(plane_origin=origin, plane_normal=normal)
         if section is None:
             return []
-        path, _ = section.to_planar(to_2D=to_2D)
+        path, _ = section.to_2D(to_2D=to_2D)
         return path.polygons_full
 
     def intersections_plane(

tidy3d/components/geometry/mesh.py

@@ -550,7 +550,7 @@ def intersections_tilted_plane(
         section = self.trimesh.section(plane_origin=origin, plane_normal=normal)
         if section is None:
             return []
-        path, _ = section.to_planar(to_2D=to_2D)
+        path, _ = section.to_2D(to_2D=to_2D)
         return path.polygons_full
 
     def intersections_plane(
@@ -603,7 +603,7 @@ def intersections_plane(
             permutation = self.unpop_axis(identity[2], identity[0:2], axis=axis)
             mapping[:3, :3] = np.array(permutation).T
 
-            section2d, _ = section.to_planar(to_2D=mapping)
+            section2d, _ = section.to_2D(to_2D=mapping)
             return list(section2d.polygons_full)
 
         except ValueError as e:

tidy3d/components/geometry/polyslab.py

@@ -634,7 +634,7 @@ def _do_intersections_tilted_plane(
         section = mesh.section(plane_origin=origin, plane_normal=normal)
         if section is None:
             return []
-        path, _ = section.to_planar(to_2D=to_2D)
+        path, _ = section.to_2D(to_2D=to_2D)
         return path.polygons_full
 
     def _intersections_normal(self, z: float):

tidy3d/components/geometry/primitives.py

@@ -468,7 +468,7 @@ def _do_intersections_tilted_plane(
         section = mesh.section(plane_origin=origin, plane_normal=normal)
         if section is None:
             return []
-        path, _ = section.to_planar(to_2D=to_2D)
+        path, _ = section.to_2D(to_2D=to_2D)
         return path.polygons_full
 
     def _intersections_normal(self, z: float):

tidy3d/components/geometry/triangulation.py

@@ -60,9 +60,11 @@ def update_convexity(vertices: list[Vertex], i: int) -> int:
     """
     result = -1 if vertices[i].convexity == 0.0 else 0
     j = (i + 1) % len(vertices)
-    vertices[i].convexity = np.cross(
-        vertices[i].coordinate - vertices[i - 1].coordinate,
-        vertices[j].coordinate - vertices[i].coordinate,
+    vertices[i].convexity = np.linalg.det(
+        [
+            vertices[i].coordinate - vertices[i - 1].coordinate,
+            vertices[j].coordinate - vertices[i].coordinate,
+        ]
     )
     if vertices[i].convexity == 0.0:
         result += 1
@@ -87,7 +89,8 @@ def is_inside(
         Flag indicating if the vertex is inside the triangle.
     """
     return all(
-        np.cross(triangle[i] - triangle[i - 1], vertex - triangle[i - 1]) > 0 for i in range(3)
+        np.linalg.det([triangle[i] - triangle[i - 1], vertex - triangle[i - 1]]) > 0
+        for i in range(3)
     )