-
Notifications
You must be signed in to change notification settings - Fork 63
Add taper support and refactor array-factor calculation #2726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 7 comments
dfe0cbd
to
ceb2158
Compare
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changes
Summary
tidy3d/plugins/microwave/array_factor.py
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! Still not sure about at
, sll
, nbar
, etc vs attenuation
, side_lobe_level
, num_constant_sidelobes
, etc. @yaugenst what's our policy on using pydantic alias feature on frontend?
782bea8
to
d152e33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work!
d152e33
to
04520ed
Compare
04520ed
to
c94883b
Compare
… calculation - Implemented taper integration to allow amplitude weighting in antenna arrays - Refactored array factor computation for improved clarity and efficiency - Updated relevant tests and documentation accordingly
c94883b
to
196794a
Compare
Add taper support to
RectangularAntennaArrayCalculator
; refactor array factor computation for clarity and efficiency.