Skip to content

Commit 426206e

Browse files
committed
fix: e2e test for realm backend
1 parent 4e3fb7d commit 426206e

File tree

3 files changed

+4
-126
lines changed

3 files changed

+4
-126
lines changed

lib/realm-backend/src/realm_training_backing.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ namespace FlexFlow {
2222

2323
using namespace Realm;
2424

25-
LocalTrainingBacking make_local_training_backing_for_computation_graph(
25+
LocalTrainingBacking make_realm_training_backing_for_computation_graph(
2626
RealmRuntimeState &runtime_state,
2727
std::unordered_map<training_tensor_guid_t, GenericTensorAccessorW> const
2828
&preallocated,
@@ -267,6 +267,8 @@ Future<void> execute_update(LocalTrainingBacking const &local_training_backing,
267267
runtime_state.worker_events[0] = e;
268268
future.set_event(e);
269269
return future;
270+
} else {
271+
return Future<void>();
270272
}
271273
}
272274

lib/realm-backend/test/src/test_e2e.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,6 @@ void top_level_task(const void *args, size_t arglen, const void *userdata,
194194
GenericTensorAccessorR first_epoch_loss = loss_values.at(0);
195195
GenericTensorAccessorR last_epoch = loss_values.back();
196196
assert(did_loss_decrease(first_epoch_loss, last_epoch));
197-
printf("passed\n");
197+
printf("passed!\n");
198198
}
199199
}

lib/realm-backend/test/src/test_update.cc

Lines changed: 0 additions & 124 deletions
This file was deleted.

0 commit comments

Comments
 (0)