Scotty Improvements #1&2 - modernize build system, fix configure for -address and -port

[jorge-leon]

I am starting to work on the Scotty build system to update it to current TEA (3.10), taking into account the comments in #7 .

[jorge-leon]

At this moment I have two branches in my clone of FlightAwares Scotty repository which build on Debian Jessie, FreeBSD 11 and Mac OS X Yosemite with Tcl stubs enabled.

• tnm-only-build: builds the Tnm package and (fails to build) scotty
• tki-only-build: builds the Tkined package and tkined

Some of the included tests for Tnm run, sunrpc beeing notably an exeption since it segfaults.
The results of the tests differ on different platforms and look strange on Mac OS X.

tkined starts up without the toolbar, so is not really usable. The problem might be with--
hardcoded paths in the libraries, which do not match TEA's idea about standard locations.
This was just a missing tkined.default file in the install target.

Interestingly, tkined segfaulted on a FreeBSD w/o X-org installed in the call to TkpGetSubfonts(),
when launched via ssh and X11 forwarding.

---

I was able to contact J. Schönwalder and Mark Newnham. Ideas is to merge the work of Mark
(icons, mostly) and to link history from 2000 to now (Scotty page in Tcler's Wiki).

[jorge-leon]

At this moment I have a fork of the FlightAware scotty repository which hopefully complies with the
bounty requirements for both Scotty bounties.

Scotty has been split into two individual directories: tnm and tkined. Inside each directory you can do:

$ autoconf
$ ./configure options ...
$ make
$ make install

Tnm has received most love, you can run make test to run the testsuite, which should terminate successfully on Debian jessie, FreeBSD 11 and Mac OSX 10.10.5.

The TODO file in each directory lists all problems encountered with the software, there will be much
more though...

[jorge-leon]

On Tnm::udp:

udp# configure does not set -address or -port on purpose. udp# send has two different use cases:

1. You want to send packets to different host/port combinations with your specific udp# object.
2. You want do send packets always to the same host/port combination.

In case 2. it is supposed to use udp# connect host port first. The udp# object is then said to
be 'connected'. All future invocations of udp# send must not specify hostand port and always
go to the same destination.

Note that the remote data hostand port are not stored in the udp# object, but rather in the
socket associated with the udp# socket.

The very simple approach of my patch is to:

• store -address
• store -port
• if both are (re)set do a udp# connect internally with the configure'd data.

Notes:

• The current approach of scotty does not allow to re-configure a connected udp# object. You
  must destroy it and create a new one.

• Order of configure items is important. You must first configure -myaddress and -myport and
  then -address and -port.

[jorge-leon]

I just created a pull reqest with what I think is a completion of the given tasks.

Scotty needs some love though, but with the new build this should be easier to manage now.

For the upd bounty I have ideas for alternative implementations/funcionality, but maybe you try this
on out first.

[resuna]

It needs some cleanup. I was going through the commits and noticed that there were some places where files were moved to backup files, and then new copies of files inserted. There's three backup files actually checked in to the repo:

tkined/generic/tkiPort.h~
tnm/generic/tnmPort.h~
tnm/tests/dns.test~

Can you clean that up, or at least verify that noting of value was lost?

[jorge-leon]

Oh! Fixed that one, nothing lost here.

Will countercheck right now, if all files are here against the original version.

[resuna]

"make test" in Tnm should be pulling in the version in the source tree, not the installed version, because that's what you're testing.

Tests began at Mon Feb 27 20:05:43 UTC 2017
dns.test
couldn't read file "/usr/local/lib/Tnm3.0.2/library/init.tcl": no such file or directory
icmp.test
command "Tnm::dns" already exists
job.test
command "Tnm::dns" already exists
map.test
command "Tnm::dns" already exists

[jorge-leon]

Files are all there.

"make test":

The original scotty works that way, it explicitely requires you to install first. The reason is, you need
nmicmpd and nmtrapd install setuid root.

However I think you are right and will rewrite this part of the Makefile accordingly. Do you think
it is okay to set these programs setuid root in the source tree first and then install them into their
final destination?

Note: nmtrapd seems not to be used by the tests.

[resuna]

Ah, OK.

There's a "make check" that seems to run out of the current directory, but it is SEGV-ing in scotty for me.

$ make check
*** Signal 11

Stop.

[jorge-leon]

That is, because it uses the C - scotty. C - scotty currently segfaults, I have added tclscotty to
compensate for now. See tnm/TODO.

[resuna]

Seems like there's a bit of work to do on this still.

[jorge-leon]

Yes, most of the items in the TODO files are already present in the original source from where I started,
e.g. scotty spins about a minute on my machine before presenting a prompt, ... So I focussed on getting the library to compile and all tests running (with tclscotty).

I need feedback where the priorities are. Do you need smx? libsmi integration?

[resuna]

We need something that is functionally complete and has no regressions on FreeBSD and Linux compared with the FlightAware version. What items in TODO are in the code you started from, and what items are new?

Mac OS X may be required too.

[jorge-leon]

To find out exactly what are the differences I will run the tests and compare. May I suppose you are
using FreeBSD 11 as primary development and test environment? Please specify which Linux
distribution in which version you are using, and with which kernel version.

Is it ok to start testing with tclscotty? The original C scotty has no stub support and is quite a rewrite of
of tclsh. So I don't know how long it takes to get this stable. The only real difference of C scotty
with respect to package require Tnm is a modified event loop which prioritizes file events.