fixed issues with has many not having a record

Author: n0nag0n

src/ActiveRecord.php

@@ -619,13 +619,15 @@ protected function &getRelation(string $name)
         }
 
         $relation = $this->relations[$name];
-        if (is_array($relation) === true) {
+        if (is_array($relation) === true && isset($relation[0])) {
             // ActiveRecordData::BELONGS_TO etc
             $relation_type_or_object_name = $relation[0];
             $relation_class = $relation[1] ?? '';
             $relation_local_key = $relation[2] ?? '';
             $relation_array_callbacks = $relation[3] ?? [];
             $relation_back_reference = $relation[4] ?? '';
+        } else {
+            return $relation;
         }
 
         if ($relation instanceof self || $relation_type_or_object_name instanceof self) {
@@ -643,7 +645,8 @@ protected function &getRelation(string $name)
         if ((!$relation instanceof self) && self::HAS_ONE === $relation_type_or_object_name) {
             $obj->eq($relation_local_key, $this->{$this->primaryKey})->find() && $relation_back_reference && $obj->__set($relation_back_reference, $this);
         } elseif (self::HAS_MANY === $relation_type_or_object_name) {
-            $this->relations[$name] = $obj->eq($relation_local_key, $this->{$this->primaryKey})->findAll();
+            $results = $obj->eq($relation_local_key, $this->{$this->primaryKey})->findAll();
+            $this->relations[$name] = $results ?: [];
             if ($relation_back_reference) {
                 foreach ($this->relations[$name] as $o) {
                     $o->__set($relation_back_reference, $this);

tests/ActiveRecordPdoIntegrationTest.php

@@ -748,4 +748,33 @@ public function testBooleanParamWithArray()
 		$sql = $record->getBuiltSql();
 		$this->assertEquals('SELECT "user".* FROM "user" WHERE "user"."name" = :ph1 AND "user"."id" IN (TRUE,FALSE) LIMIT 1', $sql);
 	}
+
+    public function testHasManyInvalidRelation()
+    {
+        $user = new class(new PDO('sqlite:test.db')) extends User {
+            public array $relations = [
+                'invalid_relation' => [] // Invalid - missing required elements
+            ];
+        };
+        
+        $user->name = 'demo';
+        $user->password = md5('demo');
+        $user->insert();
+        
+        // Should return empty array for invalid relation instead of throwing exception
+        $this->assertIsArray($user->invalid_relation);
+        $this->assertEmpty($user->invalid_relation);
+    }
+    public function testHasManyEmptyRelation()
+    {
+        $user = new User(new PDO('sqlite:test.db'));
+        $user->name = 'demo';
+        $user->password = md5('demo');
+        $user->insert();
+        
+        // No contacts exist for this user
+        $this->assertEmpty($user->contacts);
+        $this->assertIsArray($user->contacts);
+        $this->assertEquals(0, count($user->contacts));
+    }
 }