Skip to content

Commit 296ed24

Browse files
committed
fix: use slong instead of long for arb accuracy
Fixes a bug seen under Windows where 32 bit long caused showgood to fail. There are more places where long should be changed to slong but this change is enough to get the full test suite to pass on Windows
1 parent 72ba6af commit 296ed24

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/flint/_flint.pxd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -969,8 +969,8 @@ cdef extern from "arb.h":
969969
void arb_get_ubound_arf(arf_t u, const arb_t z, long prec)
970970
void arb_get_lbound_arf(arf_t u, const arb_t z, long prec)
971971
void arb_nonnegative_part(arb_t u, const arb_t x)
972-
long arb_rel_error_bits(const arb_t x)
973-
long arb_rel_accuracy_bits(const arb_t x)
972+
slong arb_rel_error_bits(const arb_t x)
973+
slong arb_rel_accuracy_bits(const arb_t x)
974974
long arb_bits(const arb_t x)
975975
void arb_randtest_exact(arb_t x, flint_rand_t state, long prec, long mag_bits)
976976
void arb_randtest_wide(arb_t x, flint_rand_t state, long prec, long mag_bits)

src/flint/functions.pyx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ cdef goodstr(x):
2424
return x.str(radius=False)
2525
raise TypeError("must have arb or acb")
2626

27-
def good(func, long prec=0, long maxprec=0, long dps=0,
28-
long maxdps=0, long padding=10, bint verbose=False, bint show=False, bint parts=True, metric=None):
27+
def good(func, slong prec=0, slong maxprec=0, slong dps=0,
28+
slong maxdps=0, slong padding=10, bint verbose=False, bint show=False, bint parts=True, metric=None):
2929
"""
3030
Evaluates *func*, automatically increasing the precision to get
3131
a result accurate to the current working precision (or the
@@ -53,7 +53,7 @@ def good(func, long prec=0, long maxprec=0, long dps=0,
5353
5454
5555
"""
56-
cdef long orig, morebits, acc
56+
cdef slong orig, morebits, acc
5757

5858
if dps > 0:
5959
prec = dps_to_prec(dps)

0 commit comments

Comments
 (0)