Skip to content

Commit 2e59716

Browse files
committed
Add an upper cap on Cython
1 parent 354629e commit 2e59716

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

pyproject.toml

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,20 @@ file = "README.md"
1616
content-type = "text/markdown"
1717

1818
[build-system]
19-
# Minimum build requirements tested in CI need to be kept in sync with this.
20-
requires = ["meson-python>=0.13", "cython>=3.0"]
19+
#
20+
# Minimum build requirements tested in CI need to be kept in sync with the
21+
# versions in requires below so that they are tested.
22+
#
23+
# The upper cap on Cython is speculative but we may as well cap it given that
24+
# it is only a build requirement and that it is not uncommon for newer Cython
25+
# versions to break the build. For example Cython 3.0 broke the build and then
26+
# Cython 3.1 broke the build again so python-flint 0.6.0 did not have any upper
27+
# cap but it should have had cython>=3.0,<3.1 i.e. precisely one minor release
28+
# of Cython works. In future we could contemplate not having an upper cap but
29+
# until we have actually witnessed a Cython 3.x release that does not break the
30+
# build we should keep the upper cap.
31+
#
32+
requires = ["meson-python>=0.13", "cython>=3.0,<3.1"]
2133
build-backend = "mesonpy"
2234

2335
[tool.spin]

0 commit comments

Comments
 (0)