Create uncocumented.pxd, move undocumented function uses

Author: Jake Moss

src/flint/flintlib/functions/fmpz_vec.pxd

@@ -68,6 +68,3 @@ cdef extern from "flint/fmpz_vec.h":
     void _fmpz_vec_dot_general_naive(fmpz_t res, const fmpz_t initial, int subtract, const fmpz_struct * a, const fmpz_struct * b, int reverse, slong len)
     void _fmpz_vec_dot_general(fmpz_t res, const fmpz_t initial, int subtract, const fmpz_struct * a, const fmpz_struct * b, int reverse, slong len)
     void _fmpz_vec_dot(fmpz_t res, const fmpz_struct * vec1, const fmpz_struct * vec2, slong len2)
-
-    # Undocumented internal functions
-    void _fmpz_vec_content(fmpz_t res, const fmpz_struct * vec, slong len)

src/flint/flintlib/functions/nmod_mpoly.pxd

@@ -133,8 +133,3 @@ cdef extern from "flint/nmod_mpoly.h":
     void nmod_mpoly_div_monagan_pearce(nmod_mpoly_t polyq, const nmod_mpoly_t poly2, const nmod_mpoly_t poly3, const nmod_mpoly_ctx_t ctx)
     void nmod_mpoly_divrem_monagan_pearce(nmod_mpoly_t q, nmod_mpoly_t r, const nmod_mpoly_t poly2, const nmod_mpoly_t poly3, const nmod_mpoly_ctx_t ctx)
     void nmod_mpoly_divrem_ideal_monagan_pearce(nmod_mpoly_struct ** q, nmod_mpoly_t r, const nmod_mpoly_t poly2, nmod_mpoly_struct * const * poly3, slong len, const nmod_mpoly_ctx_t ctx)
-
-    # These functions seem to be undocumented but appear in the header.
-    void nmod_mpoly_deflation(fmpz_struct * shift, fmpz_struct * stride, const nmod_mpoly_t A, const nmod_mpoly_ctx_t ctx)
-    void nmod_mpoly_deflate(nmod_mpoly_t A, const nmod_mpoly_t B, const fmpz_struct * shift, const fmpz_struct * stride, const nmod_mpoly_ctx_t ctx)
-    void nmod_mpoly_inflate(nmod_mpoly_t A, const nmod_mpoly_t B, const fmpz_struct * shift, const fmpz_struct * stride, const nmod_mpoly_ctx_t ctx)

src/flint/flintlib/types/nmod.pxd

@@ -13,9 +13,6 @@ cdef extern from "flint/nmod_types.h":
 
     ctypedef nmod_mat_struct nmod_mat_t[1]
 
-    # XXX: Undocumented function:
-    int nmod_mat_is_square(const nmod_mat_t mat)
-
     # Macros:
     ulong nmod_mat_entry(nmod_mat_t mat, slong i, slong j)
 

src/flint/flintlib/types/undocumented.pxd

@@ -0,0 +1,12 @@
+from flint.flintlib.types.nmod cimport nmod_mat_t
+
+from flint.flintlib.types.flint cimport fmpz_struct
+from flint.flintlib.types.nmod cimport nmod_mpoly_ctx_t, nmod_mpoly_t
+
+cdef extern from "flint/nmod_types.h":
+    int nmod_mat_is_square(const nmod_mat_t mat)
+
+cdef extern from "flint/nmod_mpoly.h":
+    void nmod_mpoly_deflation(fmpz_struct * shift, fmpz_struct * stride, const nmod_mpoly_t A, const nmod_mpoly_ctx_t ctx)
+    void nmod_mpoly_deflate(nmod_mpoly_t A, const nmod_mpoly_t B, const fmpz_struct * shift, const fmpz_struct * stride, const nmod_mpoly_ctx_t ctx)
+    void nmod_mpoly_inflate(nmod_mpoly_t A, const nmod_mpoly_t B, const fmpz_struct * shift, const fmpz_struct * stride, const nmod_mpoly_ctx_t ctx)

src/flint/types/nmod_mat.pyx

@@ -12,10 +12,8 @@ from flint.flintlib.functions.fmpz_mat cimport fmpz_mat_get_nmod_mat
 
 from flint.flintlib.types.nmod cimport nmod_mat_struct
 
-from flint.flintlib.types.nmod cimport (
-    nmod_mat_is_square,
-    nmod_mat_entry,
-)
+from flint.flintlib.types.nmod cimport nmod_mat_entry
+from flint.flintlib.types.undocumented cimport nmod_mat_is_square
 
 from flint.flintlib.functions.nmod_mat cimport (
     nmod_mat_init,

src/flint/types/nmod_mpoly.pyx

@@ -25,8 +25,6 @@ from flint.flintlib.functions.nmod_mpoly cimport (
     nmod_mpoly_compose_nmod_mpoly,
     nmod_mpoly_ctx_init,
     nmod_mpoly_ctx_modulus,
-    nmod_mpoly_deflate,
-    nmod_mpoly_deflation,
     nmod_mpoly_degrees_fmpz,
     nmod_mpoly_derivative,
     nmod_mpoly_discriminant,
@@ -43,7 +41,6 @@ from flint.flintlib.functions.nmod_mpoly cimport (
     nmod_mpoly_get_str_pretty,
     nmod_mpoly_get_term_coeff_ui,
     nmod_mpoly_get_term_exp_fmpz,
-    nmod_mpoly_inflate,
     nmod_mpoly_is_one,
     nmod_mpoly_is_zero,
     nmod_mpoly_length,
@@ -72,6 +69,11 @@ from flint.flintlib.functions.nmod_mpoly_factor cimport (
     nmod_mpoly_factor_t,
 )
 from flint.flintlib.functions.ulong_extras cimport n_is_prime
+from flint.flintlib.types.undocumented cimport (
+    nmod_mpoly_deflate,
+    nmod_mpoly_deflation,
+    nmod_mpoly_inflate,
+)
 
 from cpython.object cimport Py_EQ, Py_NE
 cimport libc.stdlib