Skip to content

Commit 8898d6f

Browse files
committed
Explain version support
1 parent 3bdb5f1 commit 8898d6f

File tree

1 file changed

+21
-19
lines changed

1 file changed

+21
-19
lines changed

meson.build

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,15 @@ mpfr_dep = dependency('mpfr')
1313
flint_dep = dependency('flint', version: ['>=' + flint_ver_lower])
1414

1515
#
16-
# For the source release, we should by default fail for newer versions of Flint
17-
# that are untested with a nice error message:
16+
# The minimum Flint version is because we know that it will not work with
17+
# earlier versions. The maximum version is because python-flint has not been
18+
# tested against versions that didn't exist at the time of release. In future
19+
# if it seems like new Flint releases do not break the build of python-flint
20+
# every time, then we can consider not using a speculative upper version cap
21+
# here.
1822
#
19-
# ../meson.build:10:12:
20-
# ERROR: Dependency lookup for flint with method 'pkgconfig' failed:
21-
# Invalid version, need 'flint' ['<3.2'] found '3.2.0'.
23+
# For the source release, we should by default fail for newer versions of Flint
24+
# that are untested with a nice error message.
2225
#
2326
# We need an option to disable this though so that we can test newer versions
2427
# of Flint. Also good to have an escape hatch for users since we don't know
@@ -28,26 +31,25 @@ if get_option('flint_version_check')
2831
if flint_dep.version().version_compare('>=' + flint_ver_upper)
2932
error('''
3033
31-
Invalid Flint version:
32-
Version needed is: @0@ <= flint < @1@
33-
Version found is: flint == @2@
34+
Invalid Flint version:
35+
Version needed is: @0@ <= flint < @1@
36+
Version found is: flint == @2@
3437
35-
By default, python-flint will only build against Flint versions that have
36-
been tested. If you are sure you want to use this version of Flint, you
37-
can disable this check with -Dflint_version_check=false.
38+
By default, python-flint will only build against Flint versions that have
39+
been tested. If you are sure you want to use this version of Flint, you can
40+
disable this check with -Dflint_version_check=false.
3841
39-
If building from the source directory using meson directly, you can do
40-
this with:
42+
If building from the source directory using meson directly, you can do this
43+
with:
4144
42-
meson setup build -Dflint_version_check=false
45+
meson setup build -Dflint_version_check=false
4346
44-
If you are installing with pip, you can do this with:
47+
If you are installing with pip, you can do this with:
4548
46-
pip install --config-settings=setup-args="-Dflint_version_check=false" python-flint
49+
pip install --config-settings=setup-args="-Dflint_version_check=false" python-flint
4750
48-
Other build frontends have similar options for passing this to meson.
49-
'''.format(flint_ver_lower, flint_ver_upper, flint_dep.version())
50-
)
51+
Other build frontends have similar options for passing this to meson.
52+
'''.format(flint_ver_lower, flint_ver_upper, flint_dep.version()))
5153
endif
5254
endif
5355

0 commit comments

Comments
 (0)