test: add polys tests for div/sqrt

Author: oscarbenjamin

src/flint/test/test_all.py

@@ -933,6 +933,7 @@ def test_fmpq_poly():
     assert raises(lambda: Q([1,[]]), TypeError)
     assert raises(lambda: Q({}), TypeError)
     assert raises(lambda: Q([1], []), TypeError)
+    assert raises(lambda: Q(1, 1, 1), TypeError)
     assert raises(lambda: Q([1], 0), ZeroDivisionError)
     assert bool(Q()) == False
     assert bool(Q([1])) == True
@@ -2735,6 +2736,8 @@ def setbad(obj, i, val):
 
         assert raises(lambda: 1 / P([1, 1]), DomainError)
         assert raises(lambda: P([1, 2, 1]) / P([1, 2]), DomainError)
+        assert raises(lambda: [] / P([1, 1]), TypeError)
+        assert raises(lambda: P([1, 1]) / [], TypeError)
 
         if is_field:
             assert P([1, 1]) // 2 == P([S(1)/2, S(1)/2])
@@ -2827,7 +2830,7 @@ def setbad(obj, i, val):
         assert raises(lambda: P([1, 2, 2]).sqrt(), DomainError)
 
         if P == flint.fmpq_poly:
-            assert raises(lambda: P([1, 2, 1], 3).sqrt(), ValueError)
+            assert raises(lambda: P([1, 2, 1], 3).sqrt(), DomainError)
             assert P([1, 2, 1], 4).sqrt() == P([1, 1], 2)
 
         assert P([]).deflation() == (P([]), 1)
@@ -3415,6 +3418,18 @@ def factor_sqf(p):
         assert S(1).sqrt() == S(1)
         assert S(4).sqrt()**2 == S(4)
 
+        if is_field:
+            for n in range(1, 10):
+                try:
+                    sqrtn = S(n).sqrt()
+                except DomainError:
+                    sqrtn = None
+                if sqrtn is None:
+                    assert raises(lambda: ((x + 1)**2/n).sqrt(), DomainError)
+                else:
+                    assert ((x + 1)**2/n).sqrt() ** 2 == (x + 1)**2/n
+                    assert raises(lambda: ((x**2 + 1)/n).sqrt(), DomainError)
+
         for i in range(-100, 100):
             try:
                 assert S(i).sqrt() ** 2 == S(i)

src/flint/types/fmpq_poly.pyx

@@ -120,9 +120,6 @@ cdef class fmpq_poly(flint_poly):
         cdef bint r
         if op != 2 and op != 3:
             raise TypeError("polynomials cannot be ordered")
-        self = any_as_fmpq_poly(self)
-        if self is NotImplemented:
-            return self
         other = any_as_fmpq_poly(other)
         if other is NotImplemented:
             return other
@@ -480,15 +477,8 @@ cdef class fmpq_poly(flint_poly):
             1/2*x + 1/2
 
         """
-        d = self.denom()
-        n = self.numer()
-        d, r = d.sqrtrem()
-        if r != 0:
-            raise ValueError(f"Cannot compute square root of {self}")
-        n = n.sqrt()
-        if n is None:
-            raise ValueError(f"Cannot compute square root of {self}")
-        return fmpq_poly(n, d)
+        d = self.denom().sqrt()
+        return fmpq_poly(self.numer().sqrt(), d)
 
     def deflation(self):
         num, n = self.numer().deflation()

src/flint/types/fmpz_mod_poly.pyx

@@ -433,10 +433,6 @@ cdef class fmpz_mod_poly(flint_poly):
     def _div_(self, other):
         cdef fmpz_mod_poly res
 
-        other = self.ctx.mod.any_as_fmpz_mod(other)
-        if other is NotImplemented:
-            return NotImplemented
-
         if other == 0:
             raise ZeroDivisionError(f"Cannot divide by zero")
         elif not other.is_unit():