reviewer feedback

Author: GiacomoPope

src/flint/types/acb_poly.pyx

@@ -197,7 +197,7 @@ cdef class acb_poly(flint_poly):
         return u
 
     def __pos__(self):
-        return self
+        return self  # ?
 
     def __neg__(s):
         u = acb_poly.__new__(acb_poly)

src/flint/types/arb_poly.pyx

@@ -194,7 +194,7 @@ cdef class arb_poly(flint_poly):
         return u
 
     def __pos__(self):
-        return self
+        return self  # ?
 
     def __neg__(s):
         u = arb_poly.__new__(arb_poly)

src/flint/types/fmpz.pyx

@@ -527,45 +527,29 @@ cdef class fmpz(flint_scalar):
             fmpz_clear(tval)
         return u
 
-    # This is the correct code when fmpz_or is fixed (in flint 3.0.0)
-
-    # def __or__(self, other):
-    #    cdef fmpz_struct tval[1]
-    #    cdef int ttype = FMPZ_UNKNOWN
-    #    ttype = fmpz_set_any_ref(tval, other)
-    #    if ttype == FMPZ_UNKNOWN:
-    #        return NotImplemented
-    #    u = fmpz.__new__(fmpz)
-    #    fmpz_or((<fmpz>u).val, self.val, tval)
-    #    if ttype == FMPZ_TMP:
-    #        fmpz_clear(tval)
-    #    return u
-
-    # def __ror__(self, other):
-    #    cdef fmpz_struct tval[1]
-    #    cdef int ttype = FMPZ_UNKNOWN
-    #    ttype = fmpz_set_any_ref(tval, other)
-    #    if ttype == FMPZ_UNKNOWN:
-    #        return NotImplemented
-    #    u = fmpz.__new__(fmpz)
-    #    fmpz_or((<fmpz>u).val, tval, self.val)
-    #    if ttype == FMPZ_TMP:
-    #        fmpz_clear(tval)
-    #    return u
-
     def __or__(self, other):
-        if typecheck(other, fmpz):
-            other = int(other)
-        if typecheck(other, int):
-            return fmpz(int(self) | other)
-        else:
+        cdef fmpz_struct tval[1]
+        cdef int ttype = FMPZ_UNKNOWN
+        ttype = fmpz_set_any_ref(tval, other)
+        if ttype == FMPZ_UNKNOWN:
             return NotImplemented
+        u = fmpz.__new__(fmpz)
+        fmpz_or((<fmpz>u).val, self.val, tval)
+        if ttype == FMPZ_TMP:
+            fmpz_clear(tval)
+        return u
 
     def __ror__(self, other):
-        if typecheck(other, int):
-            return fmpz(other | int(self))
-        else:
+        cdef fmpz_struct tval[1]
+        cdef int ttype = FMPZ_UNKNOWN
+        ttype = fmpz_set_any_ref(tval, other)
+        if ttype == FMPZ_UNKNOWN:
             return NotImplemented
+        u = fmpz.__new__(fmpz)
+        fmpz_or((<fmpz>u).val, tval, self.val)
+        if ttype == FMPZ_TMP:
+            fmpz_clear(tval)
+        return u
 
     def __xor__(self, other):
         cdef fmpz_struct tval[1]