inline arms_without_last into all callers

it's now just the first arm

Author: ada4a

clippy_lints/src/matches/match_like_matches.rs

@@ -25,34 +25,20 @@ pub(crate) fn check_if_let<'tcx>(
     if !span_contains_comment(cx.sess().source_map(), expr.span)
         && cx.typeck_results().expr_ty(expr).is_bool()
         && let Some((None, else_expr)) = arms.next_back()
-        && let arms_without_last = [(Some(let_pat), then_expr)]
         && let Some((_, first_expr)) = arms.next()
         && let Some(b0) = find_bool_lit(first_expr)
         && let Some(b1) = find_bool_lit(else_expr)
         && b0 != b1
         && arms.all(|(_, expr)| find_bool_lit(expr) == Some(b0))
     {
-        for arm in &arms_without_last {
-            if let Some(pat) = arm.0
-                && !is_lint_allowed(cx, REDUNDANT_PATTERN_MATCHING, pat.hir_id)
-                && is_some_wild(pat.kind)
-            {
-                return;
-            }
+        if !is_lint_allowed(cx, REDUNDANT_PATTERN_MATCHING, let_pat.hir_id) && is_some_wild(let_pat.kind) {
+            return;
         }
 
         // The suggestion may be incorrect, because some arms can have `cfg` attributes
         // evaluated into `false` and so such arms will be stripped before.
         let mut applicability = Applicability::MaybeIncorrect;
-        let pat = {
-            use itertools::Itertools as _;
-            arms_without_last
-                .into_iter()
-                .filter_map(|arm| arm.0)
-                .map(|pat| snippet_with_applicability(cx, pat.span, "..", &mut applicability))
-                .join(" | ")
-        };
-        let pat_and_guard = pat;
+        let pat = snippet_with_applicability(cx, let_pat.span, "..", &mut applicability);
 
         // strip potential borrows (#6503), but only if the type is a reference
         let mut ex_new = let_expr;
@@ -68,7 +54,7 @@ pub(crate) fn check_if_let<'tcx>(
             "if let .. else expression looks like `matches!` macro",
             "try",
             format!(
-                "{}matches!({}, {pat_and_guard})",
+                "{}matches!({}, {pat})",
                 if b0 { "" } else { "!" },
                 snippet_with_applicability(cx, ex_new.span, "..", &mut applicability),
             ),