Rollup merge of rust-lang#132106 - maxcabrajac:ident_ref, r=petrochenkov

matthiaskrgr · web-flow · commit a1ff955721d0 · 2024-10-25T20:33:11.000+02:00
Pass Ident by reference in ast Visitor `MutVisitor`'s version of `visit_ident` passes around `&Ident`, but `Visitor` copies `Ident`. This PR changes that r? `@petrochenkov` related to rust-lang#128974
diff --git a/clippy_utils/src/ast_utils/ident_iter.rs b/clippy_utils/src/ast_utils/ident_iter.rs
@@ -39,7 +39,7 @@ impl From<&Attribute> for IdentIter {
 struct IdentCollector(Vec<Ident>);
 
 impl Visitor<'_> for IdentCollector {
-    fn visit_ident(&mut self, ident: Ident) {
-        self.0.push(ident);
+    fn visit_ident(&mut self, ident: &Ident) {
+        self.0.push(*ident);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ impl From<&Attribute> for IdentIter {`
`39`	`39`	`struct IdentCollector(Vec<Ident>);`
`40`	`40`
`41`	`41`	`impl Visitor<'_> for IdentCollector {`
`42`		`- fn visit_ident(&mut self, ident: Ident) {`
`43`		`- self.0.push(ident);`
	`42`	`+ fn visit_ident(&mut self, ident: &Ident) {`
	`43`	`+ self.0.push(*ident);`
`44`	`44`	`}`
`45`	`45`	`}`