Skip to content

Commit c15ece1

Browse files
authored
Merge pull request #28 from easeq/master
Modified schema object keys
2 parents 4f8bda5 + d23fdc4 commit c15ece1

File tree

8 files changed

+25
-24
lines changed

8 files changed

+25
-24
lines changed

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ using REST API.
1212
- Pagination
1313
- Sortable columns
1414
- Configurable column widths
15+
- Editable table
1516
- Built in windowing to handle large dataset with thousands of rows
1617
- Customizable limiter options
1718
- Customizable toolbar with the ability to add custom renderers
@@ -217,8 +218,8 @@ const YourComponent = () =>
217218
| toolbar | array | false | \[] | Toolbar definition (Check below) |
218219
| columns | array | true | - | Columns to display |
219220
| styles | object | false | {} | Custom styles for your table |
220-
| isEditable | boolean | false | {} | Set whether the table is editable |
221-
| isEditing | boolean | false | {} | Set the default state of the table to be in editing mode |
221+
| editable | boolean | false | {} | Set whether the table is editable |
222+
| editing | boolean | false | {} | Set the default state of the table to be in editing mode |
222223
| primaryKey | string | true | {} | Set the primary key column of the table for actions like editing. |
223224

224225
#### Pagination object
@@ -278,7 +279,7 @@ Note: action of type "editable" is required when you set the table to be editabl
278279
| label | string | true | - | Label for the column |
279280
| sortable | boolean | false | true | Whether the column is sortable |
280281
| filterable | boolean | false | true | Whether the column is filterable |
281-
| isEditable | boolean | false | false | When the table is set to be editable, set whether the respective column is among the editable |
282+
| editable | boolean | false | false | When the table is set to be editable, set whether the respective column is among the editable |
282283
| visible | boolean | false | true | Whether the column is visible on load |
283284
| type | string | true | string | Available types: selection, number, date, string, image, options, actions |
284285
| width | integer | true | - | Width of the column |

demo/src/schema/basic.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ export default {
66
rowHeight: 50,
77
filterable: true,
88
headers: true,
9-
isEditable: true,
10-
isEditing: false,
9+
editable: true,
10+
editing: false,
1111
primaryKey: 'pageId',
1212
// styles: {
1313
// loader: {
@@ -222,7 +222,7 @@ export default {
222222
width: 150,
223223
filterable: true,
224224
sortable: true,
225-
// isEditable: true
225+
// editable: true
226226
}, {
227227
label: "Status",
228228
type: "options",
@@ -250,7 +250,7 @@ export default {
250250
"label": "Archived"
251251
}
252252
},
253-
isEditable: true
253+
editable: true
254254
// renderer: ({
255255
// data,
256256
// colConfig: { name, options }
@@ -262,7 +262,7 @@ export default {
262262
sortable: true,
263263
textAlign: 'left',
264264
width: 200,
265-
isEditable: true,
265+
editable: true,
266266
filterable: true,
267267
}, {
268268
label: 'Actions',

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@flipbyte/redux-datatable",
3-
"version": "0.5.0",
3+
"version": "0.5.1",
44
"description": "React-Redux data table",
55
"main": "lib/index.js",
66
"module": "es/index.js",

src/Renderer/Body/Date.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ const Date = ({
1010
isEditing,
1111
handleChange,
1212
modifiedData,
13-
colConfig: { name, textAlign, format, isEditable }
13+
colConfig: { name, textAlign, format, editable }
1414
}) => (
1515
<Fragment>
16-
{ (!isEditable || !isEditing) && <Time value={ _.get(data, name, '') } format={ format ? format : 'F j, Y, g:i a' } /> }
17-
{ !!isEditable && isEditing && (
16+
{ (!editable || !isEditing) && <Time value={ _.get(data, name, '') } format={ format ? format : 'F j, Y, g:i a' } /> }
17+
{ !!editable && isEditing && (
1818
<Row padding="0 0 5px">
1919
<Field.Input
2020
type="date"

src/Renderer/Body/Options.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ const Options = ({
99
isEditing,
1010
handleChange,
1111
modifiedData,
12-
colConfig: { name, options, isEditable }
12+
colConfig: { name, options, editable }
1313
}) => {
1414
const value = _.get(data, name);
15-
if (!isEditable || !isEditing) {
15+
if (!editable || !isEditing) {
1616
if(!options || !options[value]) {
1717
return <Fragment>{ value }</Fragment>;
1818
}
@@ -24,7 +24,7 @@ const Options = ({
2424
);
2525
}
2626

27-
return !!isEditable && isEditing && (
27+
return !!editable && isEditing && (
2828
<Row padding="0 0 5px">
2929
<Field.Select name={ name } value={ _.get(modifiedData, name) || value } onChange={ handleChange }>
3030
<option></option>

src/Renderer/Body/Text.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ const Text = ({
99
isEditing,
1010
handleChange,
1111
modifiedData,
12-
colConfig: { name, isEditable }
12+
colConfig: { name, editable }
1313
}) => (
1414
<Fragment>
15-
{ (!isEditable || !isEditing) && _.get(data, name, '') }
16-
{ !!isEditable && isEditing && (
15+
{ (!editable || !isEditing) && _.get(data, name, '') }
16+
{ !!editable && isEditing && (
1717
<Row padding="0 0 5px">
1818
<Field.Input
1919
type="text"

src/createTable.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ const renderToolbar = (
6161
thunk,
6262
internalStateUpdater,
6363
columns,
64-
isEditable,
64+
editable,
6565
isEditing,
6666
isModified,
6767
visibleColumns,
@@ -80,7 +80,7 @@ const renderToolbar = (
8080
columns={ columns }
8181
visibleColumns={ visibleColumns }
8282
isModified={ isModified }
83-
isEditable={ isEditable }
83+
isEditable={ editable }
8484
isEditing={ isEditing }
8585
/>
8686
)}
@@ -257,7 +257,7 @@ const ReduxDatatable = ( props ) => {
257257
const { config = {}, reducerName, tableData, action, thunk, loadData, state } = props;
258258
const [ tableInternalState, dispatch ] = useReducer(tableReducer, {
259259
isPrinting: false,
260-
isEditing: !!config.isEditing,
260+
isEditing: !!config.editing,
261261
visibleColumnIds: getInitialVisibleColumns(config.columns)
262262
});
263263
const {
@@ -270,7 +270,7 @@ const ReduxDatatable = ( props ) => {
270270
styles = {},
271271
columns,
272272
entity = {},
273-
isEditable,
273+
editable,
274274
primaryKey
275275
} = config;
276276
const { visibleColumnIds, isPrinting, isEditing } = tableInternalState;
@@ -317,7 +317,7 @@ const ReduxDatatable = ( props ) => {
317317
thunk,
318318
dispatch,
319319
columns,
320-
isEditable,
320+
editable,
321321
isEditing,
322322
!_.isEmpty(tableData.modified), // table data has been modified
323323
visibleColumnIds,

0 commit comments

Comments
 (0)