添加基础路由 返回错误后,仍然执行创建创建代码bug, 修复bug, #367

SliverHorn · SliverHorn · commit 6ad13c59309b · 2021-01-26T17:12:51.000+08:00
diff --git a/server/service/sys_menu.go b/server/service/sys_menu.go
@@ -89,12 +89,11 @@ func getBaseChildrenList(menu *model.SysBaseMenu, treeMap map[string][]model.Sys
 //@param: menu model.SysBaseMenu
 //@return: err error
 
-func AddBaseMenu(menu model.SysBaseMenu) (err error) {
+func AddBaseMenu(menu model.SysBaseMenu) error {
 	if !errors.Is(global.GVA_DB.Where("name = ?", menu.Name).First(&model.SysBaseMenu{}).Error, gorm.ErrRecordNotFound) {
-		err = errors.New("存在重复name，请修改name")
+		return errors.New("存在重复name，请修改name")
 	}
-	err = global.GVA_DB.Create(&menu).Error
-	return err
+	return global.GVA_DB.Create(&menu).Error
 }
 
 //@author: [piexlmax](https://github.com/piexlmax)

Original file line number	Diff line number	Diff line change
`@@ -89,12 +89,11 @@ func getBaseChildrenList(menu *model.SysBaseMenu, treeMap map[string][]model.Sys`
`89`	`89`	`//@param: menu model.SysBaseMenu`
`90`	`90`	`//@return: err error`
`91`	`91`
`92`		`-func AddBaseMenu(menu model.SysBaseMenu) (err error) {`
	`92`	`+func AddBaseMenu(menu model.SysBaseMenu) error {`
`93`	`93`	`if !errors.Is(global.GVA_DB.Where("name = ?", menu.Name).First(&model.SysBaseMenu{}).Error, gorm.ErrRecordNotFound) {`
`94`		`- err = errors.New("存在重复name，请修改name")`
	`94`	`+ return errors.New("存在重复name，请修改name")`
`95`	`95`	`}`
`96`		`- err = global.GVA_DB.Create(&menu).Error`
`97`		`- return err`
	`96`	`+ return global.GVA_DB.Create(&menu).Error`
`98`	`97`	`}`
`99`	`98`
`100`	`99`	`//@author: [piexlmax](https://github.com/piexlmax)`