Skip to content

Commit f5617b9

Browse files
committed
Add not about running tests to expression docs
1 parent 9161079 commit f5617b9

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ To learn more about JSON Schema, read [Understanding JSON Schema](https://json-s
1111
1. Describe arguments by creating a new file in [`schemas/`](schemas/) named `NewName.schema.json`. You can copy an existing function that has similar semantics to get started.
1212
2. Add the new function in [`schemas/schema.json`](schemas/schema.json) to `$defs/function`.
1313
3. Create a new file in [`examples/`](./examples) named `NewName.json` with valid and invalid examples for the new function. See other examples for inspiration.
14-
4. Implement the function in [`lib/flipper/expressions/`](../../lib/flipper/expressions/).
14+
4. Run `yarn test` in `packages/expressions` and ensure tests pass.
15+
5. Implement the function in [`lib/flipper/expressions/`](../../lib/flipper/expressions/).
16+
6. Run `rspec` to ensure tests pass.
1517

1618
See [this commit that adds Min/Max functions](https://github.com/jnunemaker/flipper/commit/ee46fab0cda21a32c3a921a8ed1fb94b0842b6b4) for a concrete example.

0 commit comments

Comments
 (0)