Merge pull request #912 from flippercloud/delegation

Fix all the warnings and turn them on for CI

Author: jnunemaker

Gemfile

@@ -31,6 +31,7 @@ gem 'mysql2'
 gem 'pg'
 gem 'cuprite'
 gem 'puma'
+gem 'warning'
 
 group(:guard) do
   gem 'guard'

Guardfile

@@ -10,7 +10,7 @@ rspec_options = {
   all_after_pass: false,
   all_on_start: false,
   failed_mode: :keep,
-  cmd: 'bundle exec rspec',
+  cmd: 'bundle exec ruby -w $(which rspec)',
 }
 
 guard 'rspec', rspec_options do

lib/flipper/adapters/http/error.rb

@@ -20,7 +20,7 @@ def initialize(response)
             if more_info = data["more_info"]
               message << "\n#{data["more_info"]}"
             end
-          rescue => exception
+          rescue
             # welp we tried
           end
 

lib/flipper/adapters/poll.rb

@@ -25,7 +25,7 @@ def initialize(poller, adapter)
         if adapter.features.empty?
           begin
             @poller.sync
-          rescue => error
+          rescue
             # TODO: Warn here that it's possible that no data has been synced
             # and flags are being evaluated without flag data being present
             # until a sync completes. We rescue to avoid flipper being down

lib/flipper/api/v1/actions/expression_gate.rb

@@ -18,7 +18,7 @@ def post
               feature.enable_expression expression
               decorated_feature = Decorators::Feature.new(feature)
               json_response(decorated_feature.as_json, 200)
-            rescue NameError, ArgumentError => exception
+            rescue NameError, ArgumentError
               json_error_response(:expression_invalid)
             end
           end

lib/flipper/cloud/configuration.rb

@@ -3,7 +3,6 @@
 require "flipper/adapters/http"
 require "flipper/adapters/poll"
 require "flipper/poller"
-require "flipper/adapters/memory"
 require "flipper/adapters/dual_write"
 require "flipper/adapters/sync/synchronizer"
 require "flipper/cloud/telemetry"

lib/flipper/export.rb

@@ -1,5 +1,3 @@
-require "flipper/adapters/memory"
-
 module Flipper
   class Export
     attr_reader :contents, :format, :version

lib/flipper/expressions/all.rb

@@ -1,5 +1,3 @@
-require "flipper/expression"
-
 module Flipper
   module Expressions
     class All

lib/flipper/feature.rb

@@ -100,9 +100,14 @@ def clear
     #
     # Returns true if enabled, false if not.
     def enabled?(*actors)
-      # Allows null object pattern. See PR for more.
-      # https://github.com/flippercloud/flipper/pull/887
-      actors = actors.flatten.reject(&:nil?).map { |actor| Types::Actor.wrap(actor) }
+      actors = Array(actors).
+        # Avoids to_ary warning that happens when passing DelegateClass of an 
+        # ActiveRecord object and using flatten here. This is tested in 
+        # spec/flipper/model/active_record_spec.rb.
+        flat_map { |actor| actor.is_a?(Array) ? actor : [actor] }. 
+        # Allows null object pattern. See PR for more. https://github.com/flippercloud/flipper/pull/887
+        reject(&:nil?). 
+        map { |actor| Types::Actor.wrap(actor) }
       actors = nil if actors.empty?
 
       # thing is left for backwards compatibility

lib/flipper/instrumentation/log_subscriber.rb

@@ -53,7 +53,6 @@ def adapter_operation(event)
 
         feature_name = event.payload[:feature_name]
         adapter_name = event.payload[:adapter_name]
-        gate_name = event.payload[:gate_name]
         operation = event.payload[:operation]
         result = event.payload[:result]