Requiring the `PStore` adapter (and a few others) changes the default adapter

[offbyone]

When I require a pstore adapter in a library in my rails app that isn't loaded automatically at engine initialization, the three lines at the bottom are replacing the global instance adapter with the newly loaded adapter. That's sort of counter-intuitive.

Is this intentional behaviour? If it is, then how do I require flipper/adapters/pstore without changing my global adapter?

[bkeepers]

Hey @offbyone, this is indeed intentional. Each adapter will configure itself as the default when it is loaded. If your app is loading more than one adapter, I would recommend being explicit about which one you want to use:

# config/initializers/flipper.rb
require "flipper/adapters/pstore"
require "flipper-active_record"

Flipper.configure do |config|
  config.adapter { Flipper::Adapters::ActiveRecord.new }
end

That's sort of counter-intuitive.

We thought it was worth the tradeoff to make it "just work". I'd love to hear a counter-argument.