tests for custom module/class methods

Author: skarim

src/analyze/javascript/detectors/analytics-source.js

@@ -43,8 +43,61 @@ function detectAnalyticsSource(node, customFunction) {
  * @returns {boolean}
  */
 function isCustomFunction(node, customFunction) {
-  return node.callee.type === NODE_TYPES.IDENTIFIER && 
-         node.callee.name === customFunction;
+  if (!customFunction) return false;
+
+  // Support dot-separated names like "CustomModule.track"
+  const parts = customFunction.split('.');
+
+  // Simple identifier (no dot)
+  if (parts.length === 1) {
+    return node.callee.type === NODE_TYPES.IDENTIFIER && node.callee.name === customFunction;
+  }
+
+  // For dot-separated names, the callee should be a MemberExpression chain.
+  if (node.callee.type !== NODE_TYPES.MEMBER_EXPRESSION) {
+    return false;
+  }
+
+  return matchesMemberChain(node.callee, parts);
+}
+
+/**
+ * Recursively verifies that a MemberExpression chain matches the expected parts.
+ * Example: parts ["CustomModule", "track"] should match `CustomModule.track()`.
+ * @param {Object} memberExpr - AST MemberExpression node
+ * @param {string[]} parts - Expected name segments (left -> right)
+ * @returns {boolean}
+ */
+function matchesMemberChain(memberExpr, parts) {
+  let currentNode = memberExpr;
+  let idx = parts.length - 1; // start from the rightmost property
+
+  while (currentNode && idx >= 0) {
+    const expectedPart = parts[idx];
+
+    // property should match current expectedPart
+    if (currentNode.type === NODE_TYPES.MEMBER_EXPRESSION) {
+      // Ensure property is Identifier and matches
+      if (
+        currentNode.property.type !== NODE_TYPES.IDENTIFIER ||
+        currentNode.property.name !== expectedPart
+      ) {
+        return false;
+      }
+
+      // Move to the object of the MemberExpression
+      currentNode = currentNode.object;
+      idx -= 1;
+    } else if (currentNode.type === NODE_TYPES.IDENTIFIER) {
+      // We reached the leftmost Identifier; it should match the first part
+      return idx === 0 && currentNode.name === expectedPart;
+    } else {
+      // Unexpected node type (e.g., ThisExpression, CallExpression, etc.)
+      return false;
+    }
+  }
+
+  return false;
 }
 
 /**

src/analyze/python/pythonTrackingAnalyzer.py

@@ -315,6 +315,12 @@ def _detect_method_call_source(self, node: ast.Call) -> Optional[str]:
         if method_name == 'track' and self._is_snowplow_tracker_call(node):
             return 'snowplow'
 
+        # Handle dot-separated custom function names like CustomModule.track
+        if self._custom_fn_name and '.' in self._custom_fn_name:
+            full_name = f"{obj_id}.{method_name}"
+            if full_name == self._custom_fn_name:
+                return 'custom'
+        
         return None
 
     def _detect_function_call_source(self, node: ast.Call) -> Optional[str]:

tests/analyzeJavaScript.test.js

@@ -325,6 +325,7 @@ test.describe('analyzeJsFile', () => {
       { sig: 'customTrackFunction2(userId, EVENT_NAME, PROPERTIES)', event: 'custom_event2' },
       { sig: 'customTrackFunction3(EVENT_NAME, PROPERTIES, userEmail)', event: 'custom_event3' },
       { sig: 'customTrackFunction4(userId, EVENT_NAME, userAddress, PROPERTIES, userEmail)', event: 'custom_event4' },
+      { sig: 'CustomModule.track(userId, EVENT_NAME, PROPERTIES)', event: 'custom_module_event' },
     ];
 
     variants.forEach(({ sig, event }) => {

tests/analyzePython.test.js

@@ -321,6 +321,7 @@ def customTrackFunction(user_id: str, event_name: str, params: Dict[str, Any]) -
       { sig: 'customTrackFunction2(userId, EVENT_NAME, PROPERTIES)', event: 'custom_event2' },
       { sig: 'customTrackFunction3(EVENT_NAME, PROPERTIES, userEmail)', event: 'custom_event3' },
       { sig: 'customTrackFunction4(userId, EVENT_NAME, userAddress, PROPERTIES, userEmail)', event: 'custom_event4' },
+      { sig: 'CustomModule.track(userId, EVENT_NAME, PROPERTIES)', event: 'custom_module_event' },
     ];
 
     for (const { sig, event } of variants) {

tests/analyzeTypeScript.test.js

@@ -857,6 +857,7 @@ test.describe('analyzeTsFile', () => {
       { sig: 'customTrackFunction2(userId, EVENT_NAME, PROPERTIES)', event: 'custom_event2' },
       { sig: 'customTrackFunction3(EVENT_NAME, PROPERTIES, userEmail)', event: 'custom_event3' },
       { sig: 'customTrackFunction4(userId, EVENT_NAME, userAddress, PROPERTIES, userEmail)', event: 'custom_event4' },
+      { sig: 'CustomModule.track(userId, EVENT_NAME, PROPERTIES)', event: 'custom_module_event' },
     ];
 
     variants.forEach(({ sig, event }) => {

tests/fixtures/javascript/main.js

@@ -164,3 +164,18 @@ customTrackFunction1('custom_event1', { foo: 'bar' });
 customTrackFunction2('user101', 'custom_event2', { foo: 'bar' });
 customTrackFunction3('custom_event3', { foo: 'bar' }, '[email protected]');
 customTrackFunction4('user202', 'custom_event4', { city: 'San Francisco' }, { foo: 'bar' }, '[email protected]');
+
+// -----------------------------------------------------------------------------
+// Dot-separated custom tracking function (module-style)
+// -----------------------------------------------------------------------------
+
+const CustomModule = {
+  track(userId, eventName, params) {
+    console.log('CustomModule.track', userId, eventName, params);
+  }
+};
+
+CustomModule.track('user321', 'custom_module_event', {
+  order_id: 'order123',
+  foo: 'bar'
+});

tests/fixtures/python/main.py

@@ -164,6 +164,17 @@ def main() -> None:
     customTrackFunction3("custom_event3", {"foo": "bar"}, "[email protected]")
     customTrackFunction4("user202", "custom_event4", {"city": "San Francisco"}, {"foo": "bar"}, "[email protected]")
 
+    # Dot-separated custom tracking function (module-style)
+    class CustomModule:
+        @staticmethod
+        def track(user_id: str, event_name: str, params: Dict[str, Any]) -> None:  # type: ignore[return-value]
+            print("CustomModule.track", user_id, event_name, params)
+
+    CustomModule.track("user444", "custom_module_event", {
+        "order_id": "order_xyz",
+        "foo": "bar"
+    })
+
 # Stub variant definitions to satisfy linters (not executed)
 
 def customTrackFunction0(event_name: str, params: Dict[str, Any]) -> None: ...

tests/fixtures/typescript/main.ts

@@ -308,3 +308,18 @@ customTrackFunction1('custom_event1', { foo: 'bar' });
 customTrackFunction2('user101', 'custom_event2', { foo: 'bar' });
 customTrackFunction3('custom_event3', { foo: 'bar' }, '[email protected]');
 customTrackFunction4('user202', 'custom_event4', { city: 'San Francisco' }, { foo: 'bar' }, '[email protected]');
+
+// -----------------------------------------------------------------------------
+// Dot-separated custom tracking function (module-style)
+// -----------------------------------------------------------------------------
+
+namespace CustomModule {
+  export function track(userId: string, eventName: string, params: Record<string, any>): void {
+    console.log('CustomModule.track', userId, eventName, params);
+  }
+}
+
+CustomModule.track('user333', 'custom_module_event', {
+  order_id: 'order_xyz',
+  foo: 'bar'
+});