Merge pull request #11 from flix-tech/handle_duplicated_completed_task

Handle duplicated completed task

Author: jacopofar

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.1.0 - 2024-07-01
+
+* The `complete()` method now returns the count of updated tasks, 0 if it was already completed
+
 ## 1.0.1 - 2024-05-27
 
 * Restrict the type yielded by the generator to never be None

postgrestq/task_queue.py

@@ -394,7 +394,7 @@ def get_many(self, amount: int) -> Sequence[
             conn.commit()
             return ret
 
-    def complete(self, task_id: Optional[UUID]) -> None:
+    def complete(self, task_id: Optional[UUID]) -> int:
         """Mark a task as completed.
 
         Marks a task as completed by setting completed_at column by
@@ -409,20 +409,31 @@ def complete(self, task_id: Optional[UUID]) -> None:
         task_id : UUID | None
             the task ID
 
+        Returns
+        -------
+        the number of updated rows: int
+
         """
         logger.info(f"Marking task {task_id} as completed")
         conn = self.conn
+        count = 0
         with conn.cursor() as cur:
             cur.execute(
                 sql.SQL(
                     """
                 UPDATE {}
                 SET completed_at = current_timestamp
-                WHERE id = %s"""
+                WHERE id = %s
+                AND completed_at is NULL"""
                 ).format(sql.Identifier(self._table_name)),
                 (task_id,),
             )
+            count = cur.rowcount
+            if count == 0:
+                logger.info(f"Task {task_id} was already completed")
+
             conn.commit()
+        return count
 
     def is_empty(self) -> bool:
         """Check if the task queue is empty.

pyproject.toml

@@ -18,7 +18,7 @@ log_cli_date_format = "%Y-%m-%d %H:%M:%S"
 
 [project]
 name = "postgres-tq"
-version = "1.0.1"
+version = "1.1.0"
 description = "Postgres Based Task Queue"
 authors = [
     {name = "FlixTech", email = "[email protected]"},