fix(player): resolve snapshot state read exception [attempt 1]

man fuck this bug

Author: rhenwinch

app/src/main/kotlin/com/flixclusive/mobile/MobileApp.kt

@@ -165,7 +165,7 @@ internal fun MobileActivity.MobileApp(viewModel: MobileAppViewModel) {
         }
     }
 
-    LaunchedEffect(cachedLinks?.streams?.size, uiState.mediaLinkResourceState) {
+    LaunchedEffect(uiState.mediaLinkResourceState) {
         if (
             uiState.mediaLinkResourceState == MediaLinkResourceState.Success &&
             currentSelectedScreen != PlayerScreenDestination
@@ -317,7 +317,10 @@ internal fun MobileActivity.MobileApp(viewModel: MobileAppViewModel) {
         }
 
         if (!uiState.mediaLinkResourceState.isIdle) {
-            window?.addFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON)
+            LaunchedEffect(true) {
+                window?.addFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON)
+            }
+
             MediaLinksBottomSheet(
                 state = uiState.mediaLinkResourceState,
                 streams = cachedLinks?.streams ?: emptyList(),
@@ -330,7 +333,9 @@ internal fun MobileActivity.MobileApp(viewModel: MobileAppViewModel) {
                 },
             )
         } else {
-            window?.clearFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON)
+            LaunchedEffect(true) {
+                window?.clearFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON)
+            }
         }
 
         AnimatedVisibility(

core/ui/mobile/src/main/kotlin/com/flixclusive/core/ui/mobile/component/provider/MediaLinksBottomSheet.kt

@@ -44,12 +44,10 @@ import androidx.compose.material3.surfaceColorAtElevation
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.MutableState
-import androidx.compose.runtime.derivedStateOf
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateListOf
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.remember
-import androidx.compose.runtime.rememberUpdatedState
 import androidx.compose.runtime.setValue
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
@@ -90,7 +88,7 @@ fun MediaLinksBottomSheet(
     onSkipLoading: () -> Unit
 ) {
     val areSubtitlesShown = remember { mutableStateOf(false) }
-    val filteredLinks by rememberUpdatedState(newValue = if (areSubtitlesShown.value) subtitles else streams)
+    val filteredLinks = if (areSubtitlesShown.value) subtitles else streams
 
     ModalBottomSheet(
         onDismissRequest = onDismiss,
@@ -258,11 +256,7 @@ private fun ProgressHeader(
     streams: List<Stream>,
     onSkipLoading: () -> Unit,
 ) {
-    val canSkipLoading by remember {
-        derivedStateOf {
-            state.isLoading && streams.isNotEmpty()
-        }
-    }
+    val canSkipLoading = state.isLoading && streams.isNotEmpty()
 
     Column(
         verticalArrangement = Arrangement.spacedBy(8.dp),
@@ -542,4 +536,4 @@ private fun MediaLinksBottomSheetPreview() {
             )
         }
     }
-}
+}

domain/provider/src/main/kotlin/com/flixclusive/domain/provider/CachedLinks.kt

@@ -8,6 +8,8 @@ import com.flixclusive.model.provider.link.Stream
 import com.flixclusive.model.provider.link.Subtitle
 import java.io.Serializable
 
+// TODO: Replace SnapshotStateList with flow
+
 /**
  *
  * A data model to hold all cached [MediaLink]s that was extracted from a provider.
@@ -49,4 +51,4 @@ data class CachedLinks(
             }
         }
     }
-}
+}