Skip to content

Commit 9212c50

Browse files
committed
General corrections
1 parent a08b51e commit 9212c50

File tree

9 files changed

+31
-72
lines changed

9 files changed

+31
-72
lines changed

.github/CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ If you wish to contribute to the **Float Toolkit** codebase, feel free to fork t
88

99
## Steps
1010

11-
1. Refer to the [documentation](https://float-toolkit.web.app/) to make sure the error is actually a bug and not a mistake of your own.
11+
1. Refer to the [documentation](https://float-toolkit.web.app) to make sure the error is actually a bug and not a mistake of your own.
1212
1. Make sure the issue hasn't already been reported or suggested.
1313
1. Fork and clone the repository, and checkout the corresponding branch (`docs` for documentation, `master` for anything else). **DO NOT** modify the `stable` branch.
1414
1. Make your changes (if necessary, add or modify documentation and tests to cover your changes).
15-
1. Run `npm run buildWithDocs` (or VSCode task _NPM: Build and generate documentation_) to run the tests and build the package and the documentation (you can use `npm link` to try it locally).
15+
1. Run `npm run buildWithDocs` (or VSCode task _NPM: Build and generate documentation_) to run the tests and build the package and documentation (you can use `npm link` to try it locally).
1616
1. [Submit a pull request](https://github.com/float-toolkit/core/compare).

.github/ISSUE_TEMPLATE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
## Before you go ANY further...
88

9-
- Refer to the [documentation](https://float-toolkit.web.app/) to make sure the error is actually a bug and not a mistake of your own.
9+
- Refer to the [documentation](https://float-toolkit.web.app) to make sure the error is actually a bug and not a mistake of your own.
1010
- Please help us process your issue efficiently and in detail by using one of our [issue templates](https://github.com/float-toolkit/core/issues/new/choose).
1111

1212
Thank you for contributing to the **Float Toolkit** codebase!
Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
name: Bug Report
22
description: Is the package not working as intended?
3-
43
title: BUG - (brief description)
54
labels:
65
- 🐞 Bug
@@ -18,30 +17,25 @@ body:
1817
1918
- type: dropdown
2019
id: affected-packages
21-
2220
attributes:
2321
label: Affected packages
2422
description: Which packages does this bug affect?
2523
multiple: true
26-
2724
options:
2825
- "@float-toolkit/core"
2926
- "@float-toolkit/react"
3027

3128
- type: input
3229
id: package-version
33-
3430
attributes:
3531
label: Package version
3632
description: Which package version are you using? You can check it in your `package.json` file or by running `npm list <package>`.
3733
placeholder: X.X.X
38-
3934
validations:
4035
required: true
4136

4237
- type: textarea
4338
id: description
44-
4539
attributes:
4640
label: Description
4741
description: |
@@ -53,13 +47,11 @@ body:
5347
2.
5448
3.
5549
...
56-
5750
validations:
5851
required: true
5952

6053
- type: textarea
6154
id: code-sample
62-
6355
attributes:
6456
label: Code sample
6557
description: |
@@ -72,53 +64,41 @@ body:
7264
7365
- type: textarea
7466
id: expected-behavior
75-
7667
attributes:
7768
label: Expected behavior
78-
7969
validations:
8070
required: true
8171

8272
- type: textarea
8373
id: actual-behavior
84-
8574
attributes:
8675
label: Actual behavior
87-
8876
validations:
8977
required: true
9078

9179
- type: dropdown
9280
id: priority
93-
9481
attributes:
9582
label: Priority
9683
description: How critical is this bug? (please be realistic)
97-
9884
options:
9985
- Minor bug (annoying, but not crucially broken)
10086
- Medium bug (needs attention)
10187
- Major bug (must be fixed immediately)
102-
10388
validations:
10489
required: true
10590

10691
- type: checkboxes
10792
id: contribution-guidelines
108-
10993
attributes:
11094
label: Contribution guidelines
11195
description: By submitting this issue, you agree that...
112-
11396
options:
11497
- label: This is a bug, not you [asking for support](https://github.com/float-toolkit/core/discussions/categories/q-a).
11598
required: true
116-
117-
- label: You have read the [documentation](https://float-toolkit.web.app/) and made sure this is not intended behavior.
99+
- label: You have read the [documentation](https://float-toolkit.web.app) and made sure this is not intended behavior.
118100
required: true
119-
120101
- label: The issue has not already been reported.
121102
required: true
122-
123103
- label: You are following the project's [Code of Conduct](https://github.com/float-toolkit/core/blob/master/.github/CODE_OF_CONDUCT.md) and [contribution guidelines](https://github.com/float-toolkit/core/blob/master/.github/CONTRIBUTING.md).
124104
required: true

.github/ISSUE_TEMPLATE/docs.yml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
name: Documentation Issue
22
description: Is there something wrong or missing in the documentation?
3-
43
title: DOCS - (brief description)
54
labels:
65
- 📄 Documentation
@@ -18,30 +17,25 @@ body:
1817
1918
- type: input
2019
id: url
21-
2220
attributes:
2321
label: URL to the affected page
2422
placeholder: https://float-toolkit.web.app/classes/FloatToolkit.html
25-
2623
validations:
2724
required: true
2825

2926
- type: textarea
3027
id: description
31-
3228
attributes:
3329
label: Description
3430
description: Please describe the issue in as much detail as possible. You can also attach images here.
3531
placeholder: |
3632
This method needs documentation...
3733
The website has a faulty link...
38-
3934
validations:
4035
required: true
4136

4237
- type: textarea
4338
id: how-to-reproduce
44-
4539
attributes:
4640
label: How to reproduce
4741
description: If this is a website bug, please describe how to reproduce it.
@@ -54,44 +48,35 @@ body:
5448
5549
- type: textarea
5650
id: expected-behavior
57-
5851
attributes:
5952
label: Expected behavior
6053

6154
- type: textarea
6255
id: actual-behavior
63-
6456
attributes:
6557
label: Actual behavior
6658

6759
- type: dropdown
6860
id: priority
69-
7061
attributes:
7162
label: Priority
7263
description: How critical is this issue? (please be realistic)
73-
7464
options:
7565
- Minor (not crucially broken)
7666
- Medium (needs attention)
7767
- Major (must be fixed immediately)
78-
7968
validations:
8069
required: true
8170

8271
- type: checkboxes
8372
id: contribution-guidelines
84-
8573
attributes:
8674
label: Contribution guidelines
8775
description: By submitting this issue, you agree that...
88-
8976
options:
9077
- label: This is a documentation issue, not you [asking for support](https://github.com/float-toolkit/core/discussions/categories/q-a).
9178
required: true
92-
9379
- label: The issue has not already been reported.
9480
required: true
95-
9681
- label: You are following the project's [Code of Conduct](https://github.com/float-toolkit/core/blob/master/.github/CODE_OF_CONDUCT.md) and [contribution guidelines](https://github.com/float-toolkit/core/blob/master/.github/CONTRIBUTING.md).
9782
required: true
Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
name: Feature Request
22
description: Do you have a suggestion or an idea for a new feature?
3-
43
title: SUGGESTION - (brief description)
54
labels:
65
- ✨ Enhancement
@@ -18,19 +17,16 @@ body:
1817
1918
- type: dropdown
2019
id: targeted-packages
21-
2220
attributes:
2321
label: Targeted packages
2422
description: Which packages should have this new feature / be considered?
2523
multiple: true
26-
2724
options:
2825
- "@float-toolkit/core"
2926
- "@float-toolkit/react"
3027

3128
- type: textarea
3229
id: description
33-
3430
attributes:
3531
label: Description
3632
description: |
@@ -40,50 +36,39 @@ body:
4036
This new feature would be very welcome...
4137
The lack of ___ is frustrating...
4238
___ should behave like this instead...
43-
4439
validations:
4540
required: true
4641

4742
- type: textarea
4843
id: example-use-cases
49-
5044
attributes:
5145
label: Example use cases
5246
description: When and where would this feature be useful?
5347
placeholder: This would be useful in situations where...
54-
5548
validations:
5649
required: true
5750

5851
- type: textarea
5952
id: other-alternatives
60-
6153
attributes:
6254
label: Other alternatives
6355
description: Have you considered any other possible approaches?
6456

6557
- type: checkboxes
6658
id: contribution-guidelines
67-
6859
attributes:
6960
label: Contribution guidelines
7061
description: By submitting this issue, you agree that...
71-
7262
options:
7363
- label: This is a suggestion, not you [asking for support](https://github.com/float-toolkit/core/discussions/categories/q-a).
7464
required: true
75-
76-
- label: You have read the [documentation](https://float-toolkit.web.app/) and made sure this is not already implemented.
65+
- label: You have read the [documentation](https://float-toolkit.web.app) and made sure this is not already implemented.
7766
required: true
78-
7967
- label: The issue has not already been suggested.
8068
required: true
81-
8269
- label: This new feature will not break any existing code.
8370
required: true
84-
8571
- label: This feature fits with Float Toolkit's philosophy and goals.
8672
required: true
87-
8873
- label: You are following the project's [Code of Conduct](https://github.com/float-toolkit/core/blob/master/.github/CODE_OF_CONDUCT.md) and [contribution guidelines](https://github.com/float-toolkit/core/blob/master/.github/CONTRIBUTING.md).
8974
required: true

.npmignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@
77
/.github
88
.gitignore
99

10+
# testing and coverage
11+
jest.config.js
12+
/coverage
13+
1014
# IDEs and editors
1115
/.idea
1216
.project

.prettierignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,7 @@
77
/docs
88

99
# testing and coverage
10-
/coverage
10+
/coverage
11+
12+
# Firebase
13+
.firebase

0 commit comments

Comments
 (0)