Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit 73528bd

Browse files
JLarkyFezVrasta
authored andcommitted
fix(typescript): invalid JSDoc annotation (#148)
Also, fixed the TS config to detect this error in future.
1 parent c8c9cb9 commit 73528bd

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

typings/react-popper.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ interface PopperProps {
2121
children: (props: ({
2222
ref: (ref: HTMLElement | null) => void,
2323
style: React.CSSProperties,
24-
placement: ?PopperJS.Placement,
24+
placement?: PopperJS.Placement,
2525
outOfBoundaries: boolean | null,
2626
scheduleUpdate: () => void,
2727
arrowProps: {

typings/tests/tsconfig.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
"jsx": "react",
66
"noEmit": true,
77
"strict": true,
8-
"skipLibCheck": true,
98
"moduleResolution": "node",
109
"typeRoots": ["./node_modules/@types"],
1110
"types": ["react"]

0 commit comments

Comments
 (0)