Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Commit 8151120

Browse files
author
Federico Zivolo
committed
fix: Make sure the exported components have a name
Previously in react dev tools they showed up as "Unknown"
1 parent 267ff7f commit 8151120

File tree

5 files changed

+33
-28
lines changed

5 files changed

+33
-28
lines changed

src/Popper.js

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ const initialStyle = {
5252

5353
const initialArrowStyle = {};
5454

55-
export class Popper extends Component<PopperProps, PopperState> {
55+
export class InnerPopper extends Component<PopperProps, PopperState> {
5656
static defaultProps = {
5757
placement: 'bottom',
5858
eventsEnabled: true,
@@ -187,10 +187,12 @@ export class Popper extends Component<PopperProps, PopperState> {
187187
const placements = PopperJS.placements;
188188
export { placements };
189189

190-
export default (props: PopperProps) => (
191-
<ManagerContext.Consumer>
192-
{({ referenceNode }) => (
193-
<Popper referenceElement={referenceNode} {...props} />
194-
)}
195-
</ManagerContext.Consumer>
196-
);
190+
export default function Popper(props: PopperProps) {
191+
return (
192+
<ManagerContext.Consumer>
193+
{({ referenceNode }) => (
194+
<InnerPopper referenceElement={referenceNode} {...props} />
195+
)}
196+
</ManagerContext.Consumer>
197+
);
198+
}

src/Popper.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import React from "react";
33
import { mount } from "enzyme";
44

55
// Private API
6-
import { Popper as InnerPopper } from "./Popper";
6+
import { InnerPopper } from "./Popper";
77

88
const mountPopper = props =>
99
mount(

src/Reference.js

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,23 @@
11
// @flow
2-
import React, { type Node } from "react";
3-
import warning from "warning";
4-
import { ManagerContext } from "./Manager";
5-
import { unwrapArray } from "./utils";
2+
import React, { type Node } from 'react';
3+
import warning from 'warning';
4+
import { ManagerContext } from './Manager';
5+
import { unwrapArray } from './utils';
66

77
type ReferenceProps = {
88
children: ({ ref: (?HTMLElement) => void }) => Node,
99
};
10-
export default ({ children }: ReferenceProps) => (
11-
<ManagerContext.Consumer>
12-
{({ getReferenceRef }) => {
13-
warning(
14-
getReferenceRef,
15-
"`Reference` should not be used outside of a `Manager` component."
16-
);
17-
return unwrapArray(children)({ ref: getReferenceRef });
18-
}}
19-
</ManagerContext.Consumer>
20-
);
10+
11+
export default function Reference({ children }: ReferenceProps) {
12+
return (
13+
<ManagerContext.Consumer>
14+
{({ getReferenceRef }) => {
15+
warning(
16+
getReferenceRef,
17+
'`Reference` should not be used outside of a `Manager` component.'
18+
);
19+
return unwrapArray(children)({ ref: getReferenceRef });
20+
}}
21+
</ManagerContext.Consumer>
22+
);
23+
}

src/__snapshots__/Popper.test.js.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Jest Snapshot v1, https://goo.gl/fbAQLP
22

33
exports[`Popper component renders the expected markup 1`] = `
4-
<Popper
4+
<InnerPopper
55
eventsEnabled={true}
66
placement="bottom"
77
positionFixed={false}
@@ -22,5 +22,5 @@ exports[`Popper component renders the expected markup 1`] = `
2222
style={Object {}}
2323
/>
2424
</div>
25-
</Popper>
25+
</InnerPopper>
2626
`;

src/__snapshots__/Reference.test.js.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ exports[`Arrow component renders the expected markup 1`] = `
1515
}
1616
}
1717
>
18-
<Component>
18+
<Reference>
1919
<Consumer>
2020
<div />
2121
</Consumer>
22-
</Component>
22+
</Reference>
2323
</Provider>
2424
`;

0 commit comments

Comments
 (0)