perf: don't recalculate when eventsEnabled changes (#203)

Author: jquense

.flowconfig

@@ -6,6 +6,7 @@
 [include]
 
 [libs]
+node_modules/popper.js/index.js.flow
 
 [lints]
 

flow-typed/npm/popper.js_v1.x.x.js

@@ -60,7 +60,7 @@
   "dependencies": {
     "babel-runtime": "6.x.x",
     "create-react-context": "^0.2.1",
-    "popper.js": "^1.14.1",
+    "popper.js": "^1.14.4",
     "prop-types": "^15.6.1",
     "typed-styles": "^0.0.5",
     "warning": "^3.0.0"

package.json

@@ -2,7 +2,7 @@
 import * as React from 'react';
 import PopperJS, {
   type Placement,
-  type Instance as PopperJS$Instance,
+  type Instance,
   type Data,
   type Modifiers,
   type ReferenceObject,
@@ -68,7 +68,7 @@ export class InnerPopper extends React.Component<PopperProps, PopperState> {
     placement: undefined,
   };
 
-  popperInstance: ?PopperJS$Instance;
+  popperInstance: ?Instance;
 
   popperNode: ?HTMLElement = null;
   arrowNode: ?HTMLElement = null;
@@ -168,12 +168,17 @@ export class InnerPopper extends React.Component<PopperProps, PopperState> {
     // If the Popper.js options have changed, update the instance (destroy + create)
     if (
       this.props.placement !== prevProps.placement ||
-      this.props.eventsEnabled !== prevProps.eventsEnabled ||
       this.props.referenceElement !== prevProps.referenceElement ||
       this.props.positionFixed !== prevProps.positionFixed
     ) {
       this.updatePopperInstance();
-      return;
+    } else if (
+      this.props.eventsEnabled !== prevProps.eventsEnabled &&
+      this.popperInstance
+    ) {
+      this.props.eventsEnabled
+        ? this.popperInstance.enableEventListeners()
+        : this.popperInstance.disableEventListeners();
     }
 
     // A placement difference in state means popper determined a new placement

src/Popper.js

@@ -5534,9 +5534,9 @@ pn@^1.1.0:
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/pn/-/pn-1.1.0.tgz#e2f4cef0e219f463c179ab37463e4e1ecdccbafb"
 
-popper.js@^1.14.1:
-  version "1.14.3"
-  resolved "https://registry.yarnpkg.com/popper.js/-/popper.js-1.14.3.tgz#1438f98d046acf7b4d78cd502bf418ac64d4f095"
+popper.js@^1.14.4:
+  version "1.14.4"
+  resolved "https://registry.yarnpkg.com/popper.js/-/popper.js-1.14.4.tgz#8eec1d8ff02a5a3a152dd43414a15c7b79fd69b6"
 
 posix-character-classes@^0.1.0:
   version "0.1.1"