fix(Bookmark#clone): Obey withHash argument

Signed-off-by: Marcel Klehr <[email protected]>

Author: marcelklehr

src/lib/Tree.ts

@@ -88,7 +88,11 @@ export class Bookmark<L extends TItemLocation> {
   }
 
   clone(withHash?: boolean):Bookmark<L> {
-    return Object.create(this)
+    const bookmark = Object.create(this)
+    if (!withHash) {
+      bookmark.hashValue = {}
+    }
+    return bookmark
   }
 
   cloneWithLocation<L2 extends TItemLocation>(withHash:boolean, location: L2): Bookmark<L2> {

src/lib/adapters/Git.ts

@@ -184,7 +184,7 @@ export default class GitAdapter extends CachingAdapter {
     Logger.log('onSyncComplete')
     clearInterval(this.lockingInterval)
 
-    this.bookmarksCache = this.bookmarksCache.clone()
+    this.bookmarksCache = this.bookmarksCache.clone(false)
     const newTreeHash = await this.bookmarksCache.hash(true)
     if (newTreeHash !== this.initialTreeHash) {
       const fileContents = this.server.bookmark_file_type === 'xbel' ? createXBEL(this.bookmarksCache, this.highestId) : createHTML(this.bookmarksCache, this.highestId)

src/lib/adapters/GoogleDrive.ts

@@ -321,7 +321,7 @@ export default class GoogleDriveAdapter extends CachingAdapter {
     Logger.log('onSyncComplete')
     clearInterval(this.lockingInterval)
 
-    this.bookmarksCache = this.bookmarksCache.clone()
+    this.bookmarksCache = this.bookmarksCache.clone(false)
     const newTreeHash = await this.bookmarksCache.hash(true)
     let xbel = createXBEL(this.bookmarksCache, this.highestId)
 

src/lib/adapters/WebDav.ts

@@ -352,7 +352,7 @@ export default class WebDavAdapter extends CachingAdapter {
     this.ended = true
     clearInterval(this.lockingInterval)
 
-    this.bookmarksCache = this.bookmarksCache.clone()
+    this.bookmarksCache = this.bookmarksCache.clone(false)
     const newTreeHash = await this.bookmarksCache.hash(true)
     if (newTreeHash !== this.initialTreeHash) {
       const fullUrl = this.getBookmarkURL()