fix(BrowserTree#getBookmarksTree): Pass parent node to next recursion

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Author: marcelklehr

src/lib/browser/BrowserTree.ts

@@ -40,7 +40,7 @@ export default class BrowserTree implements IResource<typeof ItemLocation.LOCAL>
     await this.absoluteRootPromise
     const allAccounts = await (await Account.getAccountClass()).getAllAccounts()
 
-    const recurse = (node, parentId?, rng?) => {
+    const recurse = (node, parentId?, rng?, parent?) => {
       const TITLE_BOOKMARKS_BAR = 'Bookmarks Bar',
             TITLE_OTHER_BOOKMARKS = 'Other Bookmarks',
             TITLE_BOOKMARKS_MENU = 'Bookmarks Menu',
@@ -95,25 +95,30 @@ export default class BrowserTree implements IResource<typeof ItemLocation.LOCAL>
           title: parentId ? overrideTitle || node.title : undefined,
           children: node.children
             .map((child) => {
-              return recurse(child, node.id, rng)
+              return recurse(child, node.id, rng, node)
             })
             .filter(child => !!child) // filter out `undefined` from nested accounts
         })
         folder.isRoot = isRoot
         return folder
       } else if (self.location.protocol === 'moz-extension:' && node.type === 'separator') {
         // Translate mozilla separators to floccus separators
-        const mockSeparator = (overrideTitle === TITLE_BOOKMARKS_BAR)
-          ? {title: '', page: 'vertical.html'}
-          : {title: '⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯', page: 'index.html'}
+        let title, page
+        if (parent.title === TITLE_BOOKMARKS_BAR) {
+          title = ''
+          page = 'vertical.html'
+        } else {
+          title = '⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯'
+          page = ''
+        }
         return new Tree.Bookmark({
           location: ItemLocation.LOCAL,
           id: node.id,
           parentId,
-          title: mockSeparator.title,
+          title,
           // If you have more than a quarter million separators in one folder, call me
           // Floccus breaks down much earlier atm
-          url: `https://separator.floccus.org/${mockSeparator.page}?id=${rng.int(0,1000000)}`,            
+          url: `https://separator.floccus.org/${page}?id=${rng.int(0,1000000)}`,
         })
       } else {
         return new Tree.Bookmark({