refactor: Expose isAtomic predicate on Resources

Signed-off-by: Marcel Klehr <[email protected]>

Author: marcelklehr

src/lib/Account.ts

@@ -11,7 +11,6 @@ import { Capacitor } from '@capacitor/core'
 import IAccount from './interfaces/Account'
 import Mappings from './Mappings'
 import { isTest } from './isTest'
-import CachingAdapter from './adapters/Caching'
 import * as Sentry from '@sentry/vue'
 import AsyncLock from 'async-lock'
 import CachingTreeWrapper from './CachingTreeWrapper'
@@ -378,7 +377,7 @@ export default class Account {
     if (!this.syncProcess) {
       return
     }
-    if (actionsDone && (!(this.server instanceof CachingAdapter) || 'onSyncComplete' in this.server)) {
+    if (actionsDone && !this.server.isAtomic()) {
       await this.storage.setCurrentContinuation(this.syncProcess.toJSON())
       await this.syncProcess.getMappingsInstance().persist()
     }

src/lib/CachingTreeWrapper.ts

@@ -90,4 +90,8 @@ export default class CachingTreeWrapper implements OrderFolderResource<typeof It
   cancel(): void {
     this.innerTree.cancel()
   }
+
+  isAtomic(): boolean {
+    return this.innerTree.isAtomic()
+  }
 }

src/lib/LocalTabs.ts

@@ -518,6 +518,10 @@ export default class LocalTabs implements OrderFolderResource<typeof ItemLocatio
   cancel(): void {
     this.queue.clear()
   }
+
+  isAtomic(): boolean {
+    return false
+  }
 }
 
 function awaitTabsUpdated() {

src/lib/adapters/Caching.ts

@@ -247,6 +247,10 @@ export default class CachingAdapter implements Adapter, BulkImportResource<TItem
     return Promise.resolve(true)
   }
 
+  isAtomic(): boolean {
+    return true
+  }
+
   async getCapabilities(): Promise<ICapabilities> {
     return {
       preserveOrder: true,

src/lib/adapters/Karakeep.ts

@@ -573,6 +573,10 @@ export default class KarakeepAdapter implements Adapter, IResource<typeof ItemLo
     }
   }
 
+  isAtomic(): boolean {
+    return false
+  }
+
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
   setHashSettings(hashSettings: IHashSettings): void {
     // noop

src/lib/adapters/Linkwarden.ts

@@ -375,6 +375,10 @@ export default class LinkwardenAdapter implements Adapter, IResource<typeof Item
     }
   }
 
+  isAtomic(): boolean {
+    return false
+  }
+
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
   setHashSettings(hashSettings: IHashSettings): void {
     // noop

src/lib/adapters/NextcloudBookmarks.ts

@@ -1072,6 +1072,10 @@ export default class NextcloudBookmarksAdapter implements Adapter, BulkImportRes
     }
   }
 
+  isAtomic(): boolean {
+    return false
+  }
+
   setHashSettings(hashSettings: IHashSettings): void {
     this.hashSettings = hashSettings
   }

src/lib/browser/BrowserTree.ts

@@ -409,4 +409,8 @@ export default class BrowserTree implements IResource<typeof ItemLocation.LOCAL>
   cancel(): void {
     this.queue.clear()
   }
+
+  isAtomic(): boolean {
+    return false
+  }
 }

src/lib/interfaces/Resource.ts

@@ -25,6 +25,7 @@ export interface IResource<L extends TItemLocation> {
   removeFolder(folder:Folder<L>):Promise<void>
   isAvailable():Promise<boolean>
   getCapabilities():Promise<ICapabilities>
+  isAtomic():boolean
   isUsingBrowserTabs?: () => Promise<boolean>
   cancel():void
 }