Merge pull request #211 from floooh/error-on-unsupported-texture-type

Error on unsupported texture type

Author: floooh

CHANGELOG.md

@@ -1,6 +1,13 @@
 CHANGELOG
 =========
 
+### **23-Feb-2026**
+
+sokol-shdc not throws an error when encountering unsupported texture uniform
+types (see https://github.com/floooh/sokol-tools/issues/209).
+
+PR: https://github.com/floooh/sokol-tools/pull/210
+
 ### **07-Feb-2026**
 
 When generating binary output, the metal command line compiler is now called

src/shdc/reflection.cc

@@ -149,7 +149,7 @@ Reflection Reflection::build(const Args& args, const Input& inp, const std::arra
     return res;
 }
 
-static ImageType::Enum spirtype_to_image_type(const SPIRType& type) {
+ImageType::Enum Reflection::spirtype_to_image_type(const SPIRType& type) {
     if (type.image.arrayed) {
         if (type.image.dim == spv::Dim2D) {
             return ImageType::ARRAY;

src/shdc/reflection.h

@@ -27,6 +27,9 @@ struct Reflection {
     // print a debug dump to stderr
     void dump_debug(ErrMsg::Format err_fmt) const;
 
+    // helper: convert SPIRType to ImageType
+    static ImageType::Enum spirtype_to_image_type(const spirv_cross::SPIRType& type);
+
 private:
     // create a set of unique resource bindings from shader snippet input bindings
     static Bindings merge_bindings(const std::vector<Bindings>& in_bindings, bool to_prog_bindings, ErrMsg& out_error);

src/shdc/spirvcross.cc

@@ -211,6 +211,7 @@ static ErrMsg validate_resource_restrictions(const Input& inp, const SpirvBlob&
     //   - must not be readonly
     //   - must have specific pixel formats
     // - must use separate image and sampler objects
+    // - 1D-textures / textureBuffers not supported
     //
     // FIXME: disallow vec3 arrays
     //
@@ -282,6 +283,12 @@ static ErrMsg validate_resource_restrictions(const Input& inp, const SpirvBlob&
                 return ErrMsg::error(inp.base_path, 0, fmt::format("storage image '{}': access format must be one of rgba8_snorm, rgba8i, rgba8ui, rgba16ui, rgba16i, rgba16f, r32ui, r32i, r32f, rg32ui, rg32i, rg32f, rgba32ui, rgba32i, rgba32f", simg_res.name));
         }
     }
+    for (const Resource& tex_res: res.separate_images) {
+        const SPIRType& tex_type = compiler.get_type(tex_res.type_id);
+        if (Reflection::spirtype_to_image_type(tex_type) == ImageType::INVALID) {
+            return ErrMsg::error(inp.base_path, 0, fmt::format("texture '{}': unsupported texture type (must be texture2D[MS], texture3D, textureCube or texture2DArray)", tex_res.name));
+        }
+    }
     if (res.sampled_images.size() > 0) {
         return ErrMsg::error(inp.base_path, 0, fmt::format("combined image sampler '{}' detected, please use separate textures and samplers", res.sampled_images[0].name));
     }