Allow suppressing configuration output on test (microsoft#5794)

This PR adds the `--suppress-initial-details` argument to the `winget
configure test` subcommand. In addition, it makes it so the output can
be suppressed independent of accepting the agreements. Since the
agreement states that the user is responsible for knowing the
configuration they are applying, if they've decided to suppress those
details, they should be able to without having to also pass the switch
to accept the agreement. I've validated the agreement still appears

Author: Trenly

doc/ReleaseNotes.md

@@ -1,3 +1,7 @@
 ## New in v1.28
 
 <!-- Nothing yet! -->
+
+## Bug Fixes
+* `--suppress-initial-details` now works with `winget configure test`
+* `--suppress-initial-details` no longer requires `--accept-configuration-agreements`

src/AppInstallerCLICore/Commands/ConfigureTestCommand.cpp

@@ -17,6 +17,7 @@ namespace AppInstaller::CLI
             Argument{ Execution::Args::Type::ConfigurationModulePath, Resource::String::ConfigurationModulePath, ArgumentType::Positional },
             Argument{ Execution::Args::Type::ConfigurationProcessorPath, Resource::String::ConfigurationProcessorPath, ArgumentType::Standard, Argument::Visibility::Help },
             Argument{ Execution::Args::Type::ConfigurationHistoryItem, Resource::String::ConfigurationHistoryItemArgumentDescription, ArgumentType::Standard, Argument::Visibility::Help },
+            Argument{ Execution::Args::Type::ConfigurationSuppressPrologue, Resource::String::ConfigurationSuppressPrologueArgumentDescription, ArgumentType::Flag, Argument::Visibility::Help },
             Argument{ Execution::Args::Type::ConfigurationAcceptWarning, Resource::String::ConfigurationAcceptWarningArgumentDescription, ArgumentType::Flag },
         };
     }

src/AppInstallerCLICore/Workflows/ConfigurationFlow.cpp

@@ -2057,7 +2057,7 @@ namespace AppInstaller::CLI::Workflow
         auto getDetailsOperation = configContext.Processor().GetSetDetailsAsync(configContext.Set(), ConfigurationUnitDetailFlags::ReadOnly);
         auto unification = anon::CreateProgressCancellationUnification(std::move(progressScope), getDetailsOperation);
 
-        bool suppressDetailsOutput = context.Args.Contains(Args::Type::ConfigurationAcceptWarning) && context.Args.Contains(Args::Type::ConfigurationSuppressPrologue);
+        bool suppressDetailsOutput = context.Args.Contains(Args::Type::ConfigurationSuppressPrologue);
         anon::OutputHelper outputHelper{ context };
         uint32_t unitsShown = 0;
 

src/AppInstallerCLIE2ETests/ConfigureTestCommand.cs

@@ -49,6 +49,7 @@ public void ConfigureTest_NotInDesiredState()
             var result = TestCommon.RunAICLICommand(CommandAndAgreements, TestCommon.GetTestDataFile("Configuration\\Configure_TestRepo.yml"));
             Assert.AreEqual(Constants.ErrorCode.S_FALSE, result.ExitCode);
             Assert.True(result.StdOut.Contains("System is not in the described configuration state."));
+            Assert.True(result.StdOut.Contains("Module: xE2ETestResource")); // Details from the resource should appear if the initial details are shown
         }
 
         /// <summary>
@@ -66,6 +67,7 @@ public void ConfigureTest_InDesiredState()
             var result = TestCommon.RunAICLICommand(CommandAndAgreements, TestCommon.GetTestDataFile("Configuration\\Configure_TestRepo.yml"));
             Assert.AreEqual(Constants.ErrorCode.S_OK, result.ExitCode);
             Assert.True(result.StdOut.Contains("System is in the described configuration state."));
+            Assert.True(result.StdOut.Contains("Module: xE2ETestResource")); // Details from the resource should appear if the initial details are shown
         }
 
         /// <summary>
@@ -126,6 +128,17 @@ public void ConfigureTest_DSCv3()
             Assert.True(result.StdOut.Contains("System is not in the described configuration state."));
         }
 
+        /// <summary>
+        /// Tests that --suppress-initial-details will suppress the initial details output.
+        /// </summary>
+        [Test]
+        public void ConfigureTest_SuppressInitialDetails()
+        {
+            var result = TestCommon.RunAICLICommand("configure --accept-configuration-agreements --suppress-initial-details", TestCommon.GetTestDataFile("Configuration\\Configure_TestRepo.yml"));
+            Assert.AreEqual(0, result.ExitCode);
+            Assert.False(result.StdOut.Contains("Module: xE2ETestResource")); // Details from the resource should not appear if the initial details are suppressed
+        }
+
         private void DeleteResourceArtifacts()
         {
             // Delete all .txt files in the test directory; they are placed there by the tests