Cherry-pick servicing changes for v1.11 (microsoft#5571)

This is a cherry-pick of microsoft#5570, microsoft#5568 and microsoft#5567 to the v1.11 branch.
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/5571)

Author: florelis

src/AppInstallerCommonCore/AppInstallerCommonCore.vcxproj

@@ -9,7 +9,7 @@
     <ProjectGuid>{5890d6ed-7c3b-40f3-b436-b54f640d9e65}</ProjectGuid>
     <Keyword>Win32Proj</Keyword>
     <RootNamespace>AppInstallerLoggingCore</RootNamespace>
-    <WindowsTargetPlatformVersion>10.0.22621.0</WindowsTargetPlatformVersion>
+    <WindowsTargetPlatformVersion>10.0.26100.0</WindowsTargetPlatformVersion>
     <WindowsTargetPlatformMinVersion>10.0.17763.0</WindowsTargetPlatformMinVersion>
     <WindowsSDKDesktopARM64Support>true</WindowsSDKDesktopARM64Support>
   </PropertyGroup>
@@ -500,4 +500,4 @@
     <Error Condition="!Exists('$(SolutionDir)\packages\Microsoft.Windows.CppWinRT.2.0.230706.1\build\native\Microsoft.Windows.CppWinRT.props')" Text="$([System.String]::Format('$(ErrorText)', '$(SolutionDir)\packages\Microsoft.Windows.CppWinRT.2.0.230706.1\build\native\Microsoft.Windows.CppWinRT.props'))" />
     <Error Condition="!Exists('$(SolutionDir)\packages\Microsoft.Windows.CppWinRT.2.0.230706.1\build\native\Microsoft.Windows.CppWinRT.targets')" Text="$([System.String]::Format('$(ErrorText)', '$(SolutionDir)\packages\Microsoft.Windows.CppWinRT.2.0.230706.1\build\native\Microsoft.Windows.CppWinRT.targets'))" />
   </Target>
-</Project>
+</Project>

src/PowerShell/Microsoft.WinGet.Client.Engine/Helpers/AppxModuleHelper.cs

@@ -357,6 +357,7 @@ private HashSet<Architecture> InitFrameworkArchitectures()
         {
             HashSet<Architecture> architectures = new HashSet<Architecture>();
 
+            // Read the override from the environment variable if it exists.
             string? environmentVariable = Environment.GetEnvironmentVariable(DependencyArchitectureEnvironmentVariable);
             if (environmentVariable != null)
             {
@@ -377,6 +378,7 @@ private HashSet<Architecture> InitFrameworkArchitectures()
                 return architectures;
             }
 
+            // If there are any framework packages already installed, use the same architecture as them.
             var result = this.ExecuteAppxCmdlet(
                 GetAppxPackage,
                 new Dictionary<string, object>
@@ -406,6 +408,31 @@ private HashSet<Architecture> InitFrameworkArchitectures()
                 }
             }
 
+            // Fall back to guessing from the current OS architecture.
+            // This may have issues on ARM64 because RuntimeInformation.OSArchitecture seems to just lie sometimes.
+            // See https://github.com/microsoft/winget-cli/issues/5020
+            if (architectures.Count == 0)
+            {
+                var arch = RuntimeInformation.OSArchitecture;
+                this.pwshCmdlet.Write(StreamType.Verbose, $"OS architecture: {arch.ToString()}");
+
+                if (arch == Architecture.X64)
+                {
+                    architectures.Add(Architecture.X64);
+                }
+                else if (arch == Architecture.X86)
+                {
+                    architectures.Add(Architecture.X86);
+                }
+                else if (arch == Architecture.Arm64)
+                {
+                    // Let deployment figure it out
+                    architectures.Add(Architecture.Arm64);
+                    architectures.Add(Architecture.X64);
+                    architectures.Add(Architecture.X86);
+                }
+            }
+
             return architectures;
         }
 

src/VcpkgPortOverlay/CreatePortOverlay.ps1

@@ -4,54 +4,111 @@ $OverlayRoot = $PSScriptRoot
 
 $ErrorActionPreference = "Stop"
 
-# Hacky way of getting a single directory from the vcpkg repo:
-# - Download the vcpkg repo as a zip to a memory stream
-# - Parse the zip archive
-# - Extract the files we want
-function Get-VcpkgRepoAsZipArchive
+
+# Gets the versions of a port available from the official registry.
+# This is read from the versions JSON in the main branch.
+# A version looks like this:
+#    {
+#      "git-tree": "9f5e160191038cbbd2470e534c43f051c80e7d44",
+#      "version": "2.10.19",
+#      "port-version": 3
+#    }
+function Get-PortVersions
 {
-    $vcpkgZipUri = "https://github.com/microsoft/vcpkg/archive/refs/heads/master.zip"
-    $response = Invoke-WebRequest -Uri $vcpkgZipUri
+    param(
+        [Parameter(Mandatory)]
+        [string]$Port
+    )
+
+    $initial = $Port[0]
+    $jsonUri = "https://raw.githubusercontent.com/microsoft/vcpkg/heads/master/versions/$initial-/$Port.json"
+    $versions = (Invoke-WebRequest -Uri $jsonUri).Content | ConvertFrom-Json -Depth 5
+    return $versions.versions
+}
+
+# Gets the git-tree associated with a specific version of a port.
+# The git-tree is a git object hash that represents the port directory
+# from the appropriate version of the registry.
+function Get-PortVersionGitTree
+{
+    param(
+        [Parameter(Mandatory)]
+        [string]$Port,
+        [Parameter(Mandatory)]
+        [string]$Version,
+        [Parameter(Mandatory)]
+        [string]$PortVersion
+    )
+
+    $versions = Get-PortVersions $Port
+    $versionData = $versions | Where-Object { ($_.version -eq $Version) -and ($_."port-version" -eq $portVersion) }
+    return $versionData."git-tree"
+}
+
+# Fetches and parses a git-tree as a ZIP file
+function Get-GitTreeAsArchive
+{
+    param(
+        [Parameter(Mandatory)]
+        [string]$GitTree
+    )
+
+    $archiveUri = "https://github.com/microsoft/vcpkg/archive/$gitTree.zip"
+    $response = Invoke-WebRequest -Uri $archiveUri
     $zipStream = [System.IO.MemoryStream]::new($response.Content)
     $zipArchive = [System.IO.Compression.ZipArchive]::new($zipStream)
     return $zipArchive
 }
 
-$VcpkgAsArchive = Get-VcpkgRepoAsZipArchive
-
-# Copies an port from the official registry to this overlay
-function New-PortOverlay
+# Expands an in-memory archive and writes it to disk
+function Expand-ArchiveFromMemory
 {
     param(
         [Parameter(Mandatory)]
-        [string]$Port
+        [System.IO.Compression.ZipArchive]$Archive,
+        [Parameter(Mandatory)]
+        [string]$Destination
     )
 
-    $portDir = Join-Path $OverlayRoot $Port
-
-    # Delete existing port if needed
-    if (Test-Path $portDir)
+    # Delete existing directory
+    if (Test-Path $Destination)
     {
-        Remove-Item -Force -Recurse $portDir
+        Remove-Item -Force -Recurse $Destination
     }
 
     # Remove length=0 to ignore the directory itself
-    $portZipEntries = $VcpkgAsArchive.Entries |
-        Where-Object { ($_.Length -ne 0) -and $_.FullName.StartsWith("vcpkg-master/ports/$Port/") }
-
-    if (-not $portZipEntries)
+    $entries = $archive.Entries | Where-Object { $_.Length -ne 0 }
+    if (-not $entries)
     {
-        throw "Port $port not found"
+        throw "Archive is empty"
     }
 
-    New-Item -Type Directory $portDir | Out-Null
-    foreach ($zipEntry in $portZipEntries)
+    New-Item -Type Directory $Destination | Out-Null
+    foreach ($entry in $entries)
     {
-        $targetPath = Join-Path $portDir $zipEntry.Name
-        [System.IO.Compression.ZipFileExtensions]::ExtractToFile($zipEntry, $targetPath)
+        $targetPath = Join-Path $Destination $entry.Name
+        [System.IO.Compression.ZipFileExtensions]::ExtractToFile($entry, $targetPath)
     }
 }
 
+# Creates a copy of a port version from the official registry in this overlay
+function New-PortOverlay
+{
+    param(
+        [Parameter(Mandatory)]
+        [string]$Port,
+        [Parameter(Mandatory)]
+        [string]$Version,
+        [Parameter(Mandatory)]
+        [string]$PortVersion
+    )
+
+    $gitTree = Get-PortVersionGitTree $Port $Version $PortVersion
+    $archive = Get-GitTreeAsArchive $gitTree
+    $portDir = Join-Path $OverlayRoot $Port
+    Expand-ArchiveFromMemory $archive $portDir
+}
+
 # Gets a git patch from a GitHub commit
 function Get-GitHubPatch
 {
@@ -223,13 +280,28 @@ function Update-PortSource
 
     $portDir = Join-Path $OverlayRoot $Port
 
-    Set-ParameterInPortFile $Port -ParameterName 'REF' -CurrentValuePattern '[0-9a-f]{40}' -NewValue $Commit
+    # For the REF, we also delete any comments after it that may say the wrong version
+    Set-ParameterInPortFile $Port -ParameterName 'REF' -CurrentValuePattern '[0-9a-f]{40}( #.*)?$' -NewValue "$Commit # Unreleased"
     Set-ParameterInPortFile $Port -ParameterName 'SHA512' -CurrentValuePattern '[0-9a-f]{128}' -NewValue $SourceHash
 }
 
+# Updates the port version by one.
+function Update-PortVersion
+{
+    param(
+        [Parameter(Mandatory)]
+        [string]$Port
+    )
+
+    $portJsonPath = Join-Path $OverlayRoot $Port "vcpkg.json"
+    $portDefinition = Get-Content $portJsonPath | ConvertFrom-Json
+    $portDefinition."port-version" += 1
+    $portDefinition | ConvertTo-Json -Depth 5 | Out-File $portJsonPath
+}
 
-New-PortOverlay cpprestsdk
+New-PortOverlay cpprestsdk -Version 2.10.18 -PortVersion 4
 Add-PatchToPort cpprestsdk -PatchRepo 'microsoft/winget-cli' -PatchCommit '888b4ed8f4f7d25cb05a47210e083fe29348163b' -PatchName 'add-server-certificate-validation.patch' -PatchRoot 'src/cpprestsdk/cpprestsdk'
 
-New-PortOverlay libyaml
-Update-PortSource libyaml -Commit '840b65c40675e2d06bf40405ad3f12dec7f35923' -SourceHash 'de85560312d53a007a2ddf1fe403676bbd34620480b1ba446b8c16bb366524ba7a6ed08f6316dd783bf980d9e26603a9efc82f134eb0235917b3be1d3eb4b302'
+New-PortOverlay libyaml -Version 0.2.5 -PortVersion 5
+Update-PortSource libyaml -Commit '840b65c40675e2d06bf40405ad3f12dec7f35923' -SourceHash 'de85560312d53a007a2ddf1fe403676bbd34620480b1ba446b8c16bb366524ba7a6ed08f6316dd783bf980d9e26603a9efc82f134eb0235917b3be1d3eb4b302'
+Update-PortVersion libyaml

src/VcpkgPortOverlay/README.md

@@ -8,6 +8,7 @@ The whole directory can be re-created with `.\CreatePortOverlay.ps1`
 ## cpprestsdk
 
 We add support for certificate pinning.
+Note that we use v2.10.18, which is not the latest.
 
 Changes:
 * Add patch file: `add-server-certificate-validation.patch`
@@ -18,4 +19,5 @@ Changes:
 We use an unreleased version that fixes a vulnerability.
 
 Changes:
-* New source commit: https://github.com/yaml/libyaml/commit/840b65c40675e2d06bf40405ad3f12dec7f35923
+* New source commit: https://github.com/yaml/libyaml/commit/840b65c40675e2d06bf40405ad3f12dec7f35923
+* Increase the port version so that Component Governance doesn't see it as the vulnerable version anymore