Skip to content

Commit 4cc449c

Browse files
committed
Lower the retry interval to 0.0 in tests
This is just to speed up tests, we don't really need to wait. This also uncovered a bug in the creation of the `StreamStopped` instance, which was converting `0.0` to `None`. Signed-off-by: Leandro Lucarella <[email protected]>
1 parent b023e92 commit 4cc449c

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/frequenz/client/base/streaming.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,9 @@ async def _run(self) -> None:
188188

189189
await sender.send(
190190
StreamStopped(
191-
retry_time=timedelta(seconds=interval) if interval else None,
191+
retry_time=(
192+
timedelta(seconds=interval) if interval is not None else None
193+
),
192194
exception=error,
193195
)
194196
)

tests/streaming/test_grpc_stream_broadcaster.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@ async def test_messages_on_retry(
324324
receiver_ready_event,
325325
),
326326
transform=_transformer,
327-
retry_strategy=retry.LinearBackoff(limit=1, interval=0.01, jitter=0.0),
327+
retry_strategy=retry.LinearBackoff(limit=1, interval=0.0, jitter=0.0),
328328
retry_on_exhausted_stream=True,
329329
)
330330

@@ -340,7 +340,7 @@ async def test_messages_on_retry(
340340
assert items == []
341341
assert events == [
342342
StreamStarted(),
343-
StreamStopped(timedelta(seconds=0.01), error),
343+
StreamStopped(timedelta(seconds=0.0), error),
344344
StreamStarted(),
345345
StreamStopped(None, error),
346346
StreamFatalError(error),

0 commit comments

Comments
 (0)