Lint code with ESLint

And fix the errors it picks up after using the AirBnb style guide.

Author: flother

.eslintrc

@@ -0,0 +1,36 @@
+{
+  "env": {
+    "commonjs": true,
+    "es2021": true
+  },
+  "extends": "airbnb-base",
+  "overrides": [],
+  "parserOptions": {
+    "ecmaVersion": "2022"
+  },
+  "rules": {
+    "quotes": ["error", "double"],
+    "space-before-function-paren": ["error", "never"],
+    "arrow-parens": ["error", "as-needed"],
+    "class-methods-use-this": ["off"],
+    "comma-dangle": [
+      "error",
+      {
+        "functions": "never",
+        "arrays": "always-multiline",
+        "objects": "always-multiline",
+        "imports": "always-multiline",
+        "exports": "always-multiline"
+      }
+    ]
+  },
+  "globals": {
+    "Issue": "readonly",
+    "IssueCollection": "readonly",
+    "IssueSeverity": "readonly",
+    "nova": "readonly",
+    "NotificationRequest": "readonly",
+    "Process": "readonly",
+    "Range": "readonly"
+  }
+}

.gitignore

@@ -1 +1,2 @@
 .DS_Store
+node_modules/

Scripts/Flake8Process.js

@@ -9,15 +9,16 @@ class Flake8Process {
   async process(commandArguments) {
     let flake8Path = nova.workspace.config.get("is.flother.Blake.flake8ExecutablePath");
     const maxLineLength = nova.workspace.config.get("is.flother.Blake.maxLineLength");
+    let args = commandArguments;
     if (maxLineLength) {
-      commandArguments = ["--max-line-length", maxLineLength.toString(), ...commandArguments];
+      args = ["--max-line-length", maxLineLength.toString(), ...args];
     }
     if (!flake8Path) {
       flake8Path = "/usr/bin/env";
-      commandArguments = ["flake8", ...commandArguments];
+      args = ["flake8", ...args];
     }
     return new Process(flake8Path, {
-      args: commandArguments,
+      args,
       cwd: nova.workspace.path,
       shell: true,
       stdio: ["ignore", "pipe", "pipe"],
@@ -56,17 +57,18 @@ class Flake8Process {
       request.actions = [nova.localize("OK")];
       const promise = nova.notifications.add(request);
       promise.then(
-        _ => { },
+        () => { },
         error => {
+          // eslint-disable-next-line no-console -- Last ditch attempt to put the error somewhere.
           console.error(error);
         }
       );
     }
-    this._onCompleteCallback(this.violations);
+    this.onCompleteCallback(this.violations);
   }
 
   onComplete(callback) {
-    this._onCompleteCallback = callback;
+    this.onCompleteCallback = callback;
   }
 }
 

Scripts/Formatter.js

@@ -12,16 +12,17 @@ class Formatter {
     request.actions = [nova.localize("OK")];
     const promise = nova.notifications.add(request);
     promise.then(
-      _ => { },
+      () => { },
       error => {
+        // eslint-disable-next-line no-console -- Last ditch attempt to put the error somewhere.
         console.error(error);
       }
     );
   }
 
   format(editor) {
     if (editor.document.isEmpty) {
-      return;
+      return null;
     }
 
     const textRange = new Range(0, editor.document.length);

Scripts/Violation.js

@@ -32,8 +32,8 @@ class Violation {
     return {
       code: codeMessage[0],
       message: data[3],
-      col: parseInt(data[2]),
-      row: parseInt(data[1]),
+      col: parseInt(data[2], 10),
+      row: parseInt(data[1], 10),
     };
   }
 

Scripts/main.js

@@ -1,32 +1,33 @@
 const Linter = require("./Linter");
 const Formatter = require("./Formatter");
 
-exports.activate = function() {
+exports.activate = () => {
   const linter = new Linter();
   const formatter = new Formatter();
 
   nova.workspace.onDidAddTextEditor(editor => {
-    const document = editor.document;
+    const { document } = editor;
 
     if (document.syntax !== "python") {
       return;
     }
 
     linter.lintDocument(document);
 
-    editor.onDidSave(_ => linter.lintDocument(document));
-    document.onDidChangeSyntax(document => linter.lintDocument(document));
-    editor.onWillSave(editor => {
+    editor.onDidSave(() => linter.lintDocument(document));
+    document.onDidChangeSyntax(linter.lintDocument);
+    editor.onWillSave(ed => {
       const formatOnSave = nova.workspace.config.get("is.flother.Blake.formatOnSave");
       if (formatOnSave) {
-        return formatter.format(editor);
+        return formatter.format(ed);
       }
+      return null;
     });
 
     editor.onDidDestroy(destroyedEditor => {
-      const anotherEditor = nova.workspace.textEditors.find(editor => {
-        return editor.document.path === destroyedEditor.document.path;
-      });
+      const anotherEditor = nova.workspace.textEditors.find(
+        ed => ed.document.path === destroyedEditor.document.path
+      );
       if (!anotherEditor) {
         linter.removeIssues(destroyedEditor.document.uri);
       }