Enforce passing EntryFactory to array_to_row(s) & to_entry functions (#1932)

* Enforce passing `EntryFactory` to `array_to_row(s)` & `to_entry` functions

* Enforce passing `EntryFactory` to `AggregatingFunction::result()`

Author: stloyd

documentation/components/core/building-blocks.md

@@ -41,7 +41,7 @@ $rows = array_to_rows([
     ['id' => 2, 'name' => 'user_02', 'active' => false],
     ['id' => 3, 'name' => 'user_03', 'active' => true],
     ['id' => 4, 'name' => 'user_04', 'active' => false],
-]);
+], flow_context(config())->entryFactory());
 ```
 
 ## Entry Types

documentation/upgrading.md

@@ -5,6 +5,25 @@ Please follow the instructions for your specific version to ensure a smooth upgr
 
 ---
 
+## Upgrading from 0.26.x to 0.27.x
+
+### 1) Force `EntryFactory $entryFactory` to be required on `array_to_row` & `array_to_row(s)`
+
+Before:
+```php
+to_entry('name', 'data');
+array_to_row([]);
+array_to_rows([]);
+```
+
+After:
+
+```php
+to_entry('name', 'data', flow_context(config())->entryFactory());
+array_to_row([], flow_context(config())->entryFactory());
+array_to_rows([], flow_context(config())->entryFactory());
+```
+
 ## Upgrading from 0.16.x to 0.17.x
 
 ### 1) Removed $nullable property from all types

src/core/etl/src/Flow/ETL/Config/ConfigBuilder.php

@@ -51,10 +51,9 @@ public function __construct()
         $this->randomValueGenerator = new NativePHPRandomValueGenerator();
     }
 
-    public function build() : Config
+    public function build(EntryFactory $entryFactory = new EntryFactory()) : Config
     {
         $this->id ??= 'flow_php' . $this->randomValueGenerator->string(32);
-        $entryFactory = new EntryFactory();
         $this->serializer ??= new Base64Serializer(new NativePHPSerializer());
         $this->clock ??= SystemClock::utc();
         $this->optimizer ??= new Optimizer(

src/core/etl/src/Flow/ETL/DSL/functions.php

@@ -1547,7 +1547,7 @@ function number_format(ScalarFunction|int|float $value, ScalarFunction|int $deci
  * @return Entry<mixed>
  */
 #[DocumentationDSL(module: Module::CORE, type: DSLType::DATA_FRAME)]
-function to_entry(string $name, mixed $data, EntryFactory $entryFactory = new EntryFactory()) : Entry
+function to_entry(string $name, mixed $data, EntryFactory $entryFactory) : Entry
 {
     return $entryFactory->create($name, $data);
 }
@@ -1558,7 +1558,7 @@ function to_entry(string $name, mixed $data, EntryFactory $entryFactory = new En
  * @param null|Schema $schema
  */
 #[DocumentationDSL(module: Module::CORE, type: DSLType::DATA_FRAME)]
-function array_to_row(array $data, EntryFactory $entryFactory = new EntryFactory(), array|Partitions $partitions = [], ?Schema $schema = null) : Row
+function array_to_row(array $data, EntryFactory $entryFactory, array|Partitions $partitions = [], ?Schema $schema = null) : Row
 {
     $entries = [];
 
@@ -1603,7 +1603,7 @@ function array_to_row(array $data, EntryFactory $entryFactory = new EntryFactory
  * @param null|Schema $schema
  */
 #[DocumentationDSL(module: Module::CORE, type: DSLType::DATA_FRAME)]
-function array_to_rows(array $data, EntryFactory $entryFactory = new EntryFactory(), array|Partitions $partitions = [], ?Schema $schema = null) : Rows
+function array_to_rows(array $data, EntryFactory $entryFactory, array|Partitions $partitions = [], ?Schema $schema = null) : Rows
 {
     $partitions = \is_array($partitions) ? new Partitions(...$partitions) : $partitions;
 

src/core/etl/src/Flow/ETL/Function/AggregatingFunction.php

@@ -5,7 +5,7 @@
 namespace Flow\ETL\Function;
 
 use Flow\ETL\Row;
-use Flow\ETL\Row\Entry;
+use Flow\ETL\Row\{Entry, EntryFactory};
 
 interface AggregatingFunction
 {
@@ -14,5 +14,5 @@ public function aggregate(Row $row) : void;
     /**
      * @return Entry<mixed>
      */
-    public function result() : Entry;
+    public function result(EntryFactory $entryFactory) : Entry;
 }

src/core/etl/src/Flow/ETL/Function/Average.php

@@ -8,6 +8,7 @@
 use Flow\Calculator\{Calculator, Rounding};
 use Flow\ETL\Exception\{InvalidArgumentException, RuntimeException};
 use Flow\ETL\Row\{Entry, Reference};
+use Flow\ETL\Row\EntryFactory;
 use Flow\ETL\{Row, Rows, Window};
 
 final class Average implements AggregatingFunction, WindowFunction
@@ -65,7 +66,7 @@ public function over(Window $window) : WindowFunction
         return $this;
     }
 
-    public function result() : Entry
+    public function result(EntryFactory $entryFactory) : Entry
     {
         if (!$this->ref->hasAlias()) {
             $this->ref->as($this->ref->to() . '_avg');

src/core/etl/src/Flow/ETL/Function/Collect.php

@@ -8,6 +8,7 @@
 use Flow\ETL\Exception\InvalidArgumentException;
 use Flow\ETL\Row;
 use Flow\ETL\Row\{Entry, Reference};
+use Flow\ETL\Row\EntryFactory;
 
 final class Collect implements AggregatingFunction
 {
@@ -38,12 +39,12 @@ public function aggregate(Row $row) : void
     /**
      * @return Entry<mixed>
      */
-    public function result() : Entry
+    public function result(EntryFactory $entryFactory) : Entry
     {
         if (!$this->ref->hasAlias()) {
             $this->ref->as($this->ref->name() . '_collection');
         }
 
-        return to_entry($this->ref->name(), $this->collection);
+        return to_entry($this->ref->name(), $this->collection, $entryFactory);
     }
 }

src/core/etl/src/Flow/ETL/Function/CollectUnique.php

@@ -8,6 +8,7 @@
 use Flow\ETL\Exception\InvalidArgumentException;
 use Flow\ETL\Row;
 use Flow\ETL\Row\{Entry, Reference};
+use Flow\ETL\Row\EntryFactory;
 
 final class CollectUnique implements AggregatingFunction
 {
@@ -43,12 +44,12 @@ public function aggregate(Row $row) : void
     /**
      * @return Entry<mixed>
      */
-    public function result() : Entry
+    public function result(EntryFactory $entryFactory) : Entry
     {
         if (!$this->ref->hasAlias()) {
             $this->ref->as($this->ref->name() . '_collection_unique');
         }
 
-        return to_entry($this->ref->name(), $this->collection);
+        return to_entry($this->ref->name(), $this->collection, $entryFactory);
     }
 }

src/core/etl/src/Flow/ETL/Function/Count.php

@@ -7,6 +7,7 @@
 use function Flow\ETL\DSL\int_entry;
 use Flow\ETL\Exception\{InvalidArgumentException, RuntimeException};
 use Flow\ETL\Row\{Entry, Reference};
+use Flow\ETL\Row\EntryFactory;
 use Flow\ETL\{Row, Rows, Window};
 
 final class Count implements AggregatingFunction, WindowFunction
@@ -62,7 +63,7 @@ public function over(Window $window) : WindowFunction
     /**
      * @return Entry<?int>
      */
-    public function result() : Entry
+    public function result(EntryFactory $entryFactory) : Entry
     {
         if (!$this->ref) {
             return int_entry('_count', $this->count);

src/core/etl/src/Flow/ETL/Function/First.php

@@ -8,6 +8,7 @@
 use Flow\ETL\Exception\InvalidArgumentException;
 use Flow\ETL\Row;
 use Flow\ETL\Row\{Entry, Reference};
+use Flow\ETL\Row\EntryFactory;
 
 final class First implements AggregatingFunction
 {
@@ -35,7 +36,7 @@ public function aggregate(Row $row) : void
     /**
      * @return Entry<mixed>
      */
-    public function result() : Entry
+    public function result(EntryFactory $entryFactory) : Entry
     {
         $name = $this->ref->hasAlias() ? $this->ref->name() : $this->ref->name() . '_first';