Fixed date conversion to parquet (#1647)

Author: norberttech

.nix/shell/starship.sh

@@ -49,13 +49,14 @@ pkgs.mkShell {
     ;
 
     shellHook = ''
-    if [ -f "./.nix/shell/starship.toml" ]; then
-        export STARSHIP_CONFIG="./.nix/shell/starship.toml"
+    if [ -f "$PWD/.nix/shell/starship.toml" ]; then
+        export STARSHIP_CONFIG="$PWD/.nix/shell/starship.toml"
     else
-        export STARSHIP_CONFIG="./.nix/shell/starship.toml.dist"
+        export STARSHIP_CONFIG="$PWD/.nix/shell/starship.toml.dist"
     fi
 
     eval "$(${pkgs.starship}/bin/starship init bash)"
+
     clear
     figlet "Flow PHP"
     '';

shell.nix

@@ -38,11 +38,17 @@ private function dateTimeToNumberOfDays(\DateTime|\DateTimeImmutable $date) : in
         $epoch = new \DateTimeImmutable('1970-01-01 00:00:00 UTC');
         $interval = $epoch->diff($date->setTime(0, 0, 0, 0));
 
-        return (int) $interval->format('%a');
+        return $interval->invert ? -(int) $interval->format('%a') : (int) $interval->format('%a');
     }
 
     private function numberOfDaysToDateTime(int $data) : \DateTimeImmutable
     {
-        return (new \DateTimeImmutable('1970-01-01 00:00:00 UTC'))->add(new \DateInterval('P' . $data . 'D'));
+        $interval = new \DateInterval('P' . \abs($data) . 'D');
+
+        if ($data < 0) {
+            $interval->invert = 1;
+        }
+
+        return (new \DateTimeImmutable('1970-01-01 00:00:00 UTC'))->add($interval);
     }
 }

src/lib/parquet/src/Flow/Parquet/Data/Converter/Int32DateConverter.php

@@ -94,6 +94,32 @@ public function test_writing_date_column() : void
         \unlink($path);
     }
 
+    public function test_writing_date_column_before_1970() : void
+    {
+        $path = __DIR__ . '/var/test-writer-parquet-test-' . generate_random_string() . '.parquet';
+
+        $writer = new Writer();
+        $schema = Schema::with(FlatColumn::date('date'));
+
+        $faker = Factory::create();
+
+        $inputData = \array_merge(...\array_map(static fn (int $i) : array => [
+            [
+                'date' => \DateTimeImmutable::createFromMutable($faker->dateTimeBetween('1930-01-01', '1969-01-01'))->setTime(0, 0, 0, 0),
+            ],
+        ], \range(1, 100)));
+
+        $writer->write($path, $schema, $inputData);
+
+        self::assertEquals(
+            $inputData,
+            \iterator_to_array((new Reader())->read($path)->values())
+        );
+
+        self::assertTrue(\file_exists($path));
+        \unlink($path);
+    }
+
     public function test_writing_date_nullable_column() : void
     {
         $path = __DIR__ . '/var/test-writer-parquet-test-' . generate_random_string() . '.parquet';
@@ -573,6 +599,31 @@ public function test_writing_timestamp_column() : void
         \unlink($path);
     }
 
+    public function test_writing_timestamp_column_for_years_before_1970() : void
+    {
+        $path = __DIR__ . '/var/test-writer-parquet-test-' . generate_random_string() . '.parquet';
+
+        $writer = new Writer();
+        $schema = Schema::with(FlatColumn::dateTime('dateTime'));
+
+        $faker = Factory::create();
+
+        $inputData = \array_merge(...\array_map(static fn (int $i) : array => [
+            [
+                'dateTime' => $faker->dateTimeBetween('1930-01-01', '1969-01-01'),
+            ],
+        ], \range(1, 100)));
+
+        $writer->write($path, $schema, $inputData);
+
+        self::assertEquals(
+            $inputData,
+            \iterator_to_array((new Reader())->read($path)->values())
+        );
+        self::assertTrue(\file_exists($path));
+        \unlink($path);
+    }
+
     public function test_writing_timestamp_nullable_column() : void
     {
         $path = __DIR__ . '/var/test-writer-parquet-test-' . generate_random_string() . '.parquet';