Bugfix for XMLElementEntry losing parent relation (#1992)

Author: stloyd

src/core/etl/src/Flow/ETL/Row/Entry/XMLElementEntry.php

@@ -40,9 +40,6 @@ public function __construct(
             }
 
             $value = $doc->documentElement;
-        } elseif ($value instanceof \DOMElement) {
-            /** @var \DOMElement $value */
-            $value = (new \DOMDocument())->importNode($value, true);
         }
 
         $this->metadata = $metadata ?: Metadata::empty();

src/core/etl/tests/Flow/ETL/Tests/Unit/Row/Entry/XMLElementEntryTest.php

@@ -12,12 +12,25 @@
 
 final class XMLElementEntryTest extends FlowTestCase
 {
+    public function test_create_from_dom_document() : void
+    {
+        $document = new \DOMDocument();
+        $document->loadXML('<root><name>User Name</name><id>01</id></root>');
+
+        /* @phpstan-ignore-next-line */
+        $entry = xml_element_entry('node', $document->documentElement->firstChild);
+
+        self::assertInstanceOf(\DOMElement::class, $entry->value());
+        self::assertSame('<name>User Name</name>', $entry->toString());
+        self::assertSame($document->documentElement, $entry->value()->parentNode);
+    }
+
     public function test_create_from_string() : void
     {
         $entry = xml_element_entry('node', '<node attr="test">value</node>');
 
         self::assertInstanceOf(\DOMElement::class, $entry->value());
-        self::assertEquals('<node attr="test">value</node>', $entry->toString());
+        self::assertSame('<node attr="test">value</node>', $entry->toString());
     }
 
     public function test_create_from_string_fails_with_invalid_xml() : void
@@ -34,7 +47,7 @@ public function test_duplicating_entry() : void
         $duplicated = $entry->duplicate();
 
         self::assertNotSame($entry, $duplicated);
-        self::assertEquals($entry->toString(), $duplicated->toString());
+        self::assertSame($entry->toString(), $duplicated->toString());
     }
 
     public function test_serialization() : void