Integrate rector and upgrade codebase to php 82 (#1339)

* Configure rector for src and tests

* Upgraded codebase to php 8.2

Author: norberttech

bin/docs.php

@@ -63,7 +63,7 @@ public function execute(InputInterface $input, OutputInterface $output) : int
             $normalizedFunctions[] = $function->normalize();
         }
 
-        \file_put_contents(__DIR__ . '/../' . \ltrim($input->getArgument('output'), '/'), \json_encode($normalizedFunctions));
+        \file_put_contents(__DIR__ . '/../' . \ltrim((string) $input->getArgument('output'), '/'), \json_encode($normalizedFunctions));
 
         return Command::SUCCESS;
     }

rector.src.php

@@ -0,0 +1,18 @@
+<?php
+
+use Rector\Config\RectorConfig;
+use Rector\Set\ValueObject\LevelSetList;
+
+return RectorConfig::configure()
+    ->withPaths([
+        __DIR__ . '/bin',
+        __DIR__ . '/examples',
+        __DIR__ . '/src/core/etl/src',
+        __DIR__ . '/src/cli/src',
+        __DIR__ . '/src/adapter/*/src',
+        __DIR__ . '/src/bridge/*/*/src',
+        __DIR__ . '/src/tools/*/*/src',
+    ])
+    ->withSets([
+        LevelSetList::UP_TO_PHP_82
+    ]);

rector.tests.php

@@ -0,0 +1,20 @@
+<?php
+
+use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\StaticCall\RemoveParentCallWithoutParentRector;
+use Rector\Set\ValueObject\LevelSetList;
+
+return RectorConfig::configure()
+    ->withPaths([
+        __DIR__ . '/src/core/etl/tests',
+        __DIR__ . '/src/cli/tests',
+        __DIR__ . '/src/adapter/*/tests',
+        __DIR__ . '/src/bridge/*/*/tests',
+        __DIR__ . '/src/tools/*/*/tests',
+    ])
+    ->withSets([
+        LevelSetList::UP_TO_PHP_82
+    ])
+    ->withSkip([
+        RemoveParentCallWithoutParentRector::class
+    ]);

src/adapter/etl-adapter-avro/src/Flow/ETL/Adapter/Avro/FlixTech/AvroLoader.php

@@ -9,11 +9,11 @@
 use Flow\ETL\{Exception\RuntimeException, FlowContext, Loader, Rows};
 use Flow\Filesystem\Path;
 
-final class AvroLoader implements Closure, Loader, Loader\FileLoader
+final readonly class AvroLoader implements Closure, Loader, Loader\FileLoader
 {
     public function __construct(
-        private readonly Path $path,
-        private readonly ?Schema $schema = null,
+        private Path $path,
+        private ?Schema $schema = null,
     ) {
         throw new RuntimeException('Avro integration was abandoned due to lack of availability of good Avro libraries.');
     }

src/adapter/etl-adapter-csv/src/Flow/ETL/Adapter/CSV/CSVDetector.php

@@ -11,17 +11,11 @@
 
 final class CSVDetector
 {
-    private ?Option $fallback;
-
     private Options $options;
 
-    private SourceStream $stream;
-
-    public function __construct(SourceStream $stream, ?Option $fallback = new Option(',', '"', '\\'), ?Options $options = null)
+    public function __construct(private readonly SourceStream $stream, private readonly ?Option $fallback = new Option(',', '"', '\\'), ?Options $options = null)
     {
-        $this->stream = $stream;
         $this->options = $options ?? Options::all();
-        $this->fallback = $fallback;
     }
 
     /**

src/adapter/etl-adapter-csv/src/Flow/ETL/Adapter/CSV/Detector/Options.php

@@ -6,19 +6,13 @@
 
 use Flow\ETL\Adapter\CSV\Exception\CantDetectCSVOptions;
 
-final class Options
+final readonly class Options
 {
-    /**
-     * @var array<Option>
-     */
-    private array $options;
-
     /**
      * @param array<Option> $options
      */
-    public function __construct(array $options)
+    public function __construct(private array $options)
     {
-        $this->options = $options;
     }
 
     public static function all() : self

src/adapter/etl-adapter-csv/src/Flow/ETL/Adapter/CSV/RowsNormalizer.php

@@ -7,9 +7,9 @@
 use Flow\ETL\Adapter\CSV\RowsNormalizer\EntryNormalizer;
 use Flow\ETL\Rows;
 
-final class RowsNormalizer
+final readonly class RowsNormalizer
 {
-    public function __construct(private readonly EntryNormalizer $entryNormalizer)
+    public function __construct(private EntryNormalizer $entryNormalizer)
     {
     }
 

src/adapter/etl-adapter-csv/src/Flow/ETL/Adapter/CSV/RowsNormalizer/EntryNormalizer.php

@@ -8,11 +8,11 @@
 use Flow\ETL\PHP\Type\Caster;
 use Flow\ETL\Row\Entry;
 
-final class EntryNormalizer
+final readonly class EntryNormalizer
 {
     public function __construct(
-        private readonly Caster $caster,
-        private readonly string $dateTimeFormat = \DateTimeInterface::ATOM,
+        private Caster $caster,
+        private string $dateTimeFormat = \DateTimeInterface::ATOM,
     ) {
     }
 

src/adapter/etl-adapter-csv/tests/Flow/ETL/Adapter/CSV/Tests/Benchmark/CSVExtractorBench.php

@@ -9,9 +9,9 @@
 use PhpBench\Attributes\Groups;
 
 #[Groups(['extractor'])]
-final class CSVExtractorBench
+final readonly class CSVExtractorBench
 {
-    private readonly FlowContext $context;
+    private FlowContext $context;
 
     public function __construct()
     {

src/adapter/etl-adapter-doctrine/src/Flow/ETL/Adapter/Doctrine/DbalDataFrameFactory.php

@@ -15,7 +15,7 @@ final class DbalDataFrameFactory implements DataFrameFactory
     /**
      * @var array<QueryParameter>
      */
-    private array $parameters;
+    private readonly array $parameters;
 
     private ?Schema $schema = null;