Add a new DOMElementParent function

Author: stloyd

src/core/etl/src/Flow/ETL/Function/DOMElementParent.php

@@ -36,22 +36,14 @@ public function eval(Row $row, FlowContext $context) : \DOMNode|HTMLElement|null
             $node = $node->documentElement;
         }
 
-        if (\is_array($node) && \count($node)) {
-            $node = \reset($node);
-        }
-
         if ($node === null) {
-            return $context->functions()->invalidResult(new InvalidArgumentException('DOMElementParent requires non-null DOMNode'));
+            return $context->functions()->invalidResult(new InvalidArgumentException('DOMElementParent requires non-null DOMNode or HTMLElement.'));
         }
 
         if ($node instanceof HTMLElement) {
             return $node->parentElement;
         }
 
-        if ($node instanceof \DOMNode) {
-            return $node->parentNode;
-        }
-
-        return null;
+        return $node->parentNode;
     }
 }

src/core/etl/tests/Flow/ETL/Tests/Unit/Function/DOMElementParentTest.php

@@ -6,11 +6,27 @@
 
 use function Flow\ETL\DSL\{config, flow_context, ref, row};
 use Dom\HTMLDocument;
+use Flow\ETL\Exception\InvalidArgumentException;
+use Flow\ETL\Function\ExecutionMode;
 use PHPUnit\Framework\Attributes\RequiresPhp;
 use PHPUnit\Framework\TestCase;
 
 final class DOMElementParentTest extends TestCase
 {
+    #[RequiresPhp('>= 8.4')]
+    public function test_html_fails_when_parent_not_available_in_strict_mode() : void
+    {
+        $element = HTMLDocument::createFromString('<span>bar</span>', \LIBXML_HTML_NOIMPLIED | \LIBXML_NOERROR);
+
+        $context = flow_context(config());
+        $context->functions()->setMode(ExecutionMode::STRICT);
+
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('DOMElementParent requires non-null DOMNode or HTMLElement.');
+
+        ref('value')->domElementParent()->eval(row($context->entryFactory()->create('value', $element->documentElement->parentElement)), $context);
+    }
+
     #[RequiresPhp('>= 8.4')]
     public function test_html_getting_parent_element() : void
     {
@@ -32,6 +48,23 @@ public function test_html_getting_parent_element_when_not_available() : void
         );
     }
 
+    public function test_xml_fails_when_parent_not_available_in_strict_mode() : void
+    {
+        $xml = new \DOMDocument();
+        $xml->loadXML('<root>foobar</root>');
+
+        $context = flow_context(config());
+        $context->functions()->setMode(ExecutionMode::STRICT);
+
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('DOMElementParent requires non-null DOMNode or HTMLElement.');
+
+        self::assertEquals(
+            $xml,
+            ref('value')->domElementParent()->eval(row($context->entryFactory()->create('value', $xml->parentNode)), $context)
+        );
+    }
+
     public function test_xml_getting_parent_element() : void
     {
         $xml = new \DOMDocument();
@@ -54,4 +87,15 @@ public function test_xml_getting_parent_element_when_not_available() : void
             ref('value')->domElementParent()->eval(row(flow_context(config())->entryFactory()->create('value', $xml->documentElement)), flow_context())
         );
     }
+
+    public function test_xml_getting_parent_element_when_passing_document() : void
+    {
+        $xml = new \DOMDocument();
+        $xml->loadXML('<root>foobar</root>');
+
+        self::assertEquals(
+            $xml,
+            ref('value')->domElementParent()->eval(row(flow_context(config())->entryFactory()->create('value', $xml)), flow_context())
+        );
+    }
 }